PHP: make a function

Question

function fullname($id){
$query = mysql_query("SELECT firstname, lastname FROM users WHERE id = '$id'");
$row = mysql_fetch_array($query);
$full_name = $row["firstname"] . " ".$row["lastname"];

return $full_name;
}

I want to grab firstname and lastname, put them together, and then echo it back, is this right?

Have you tried? Does it work? If yes, it is probably right. Just a note: If the id is an integer, you should not enclose it in single quotes: "SELECT firstname, lastname FROM users WHERE id = $id". — Felix Kling
– Felix Kling, Commented Sep 26, 2010 at 11:33
It should work if your $query work. But if you ask is it works, it's it doesn't work, nop ? — Vinzius
– Vinzius, Commented Sep 26, 2010 at 11:34

Irfan EVRENS · Accepted Answer · 2010-09-26 11:34:59Z

1

if id field is an integer you do not have to use like 'id'

this is the correct line of code

$query = mysql_query("SELECT firstname, lastname FROM users WHERE id = $id");

answered Sep 26, 2010 at 11:34

Irfan EVRENS

4594 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

sholsinger Over a year ago

Better make sure $id is in fact a number first. if(!is_numeric($id)) {return false;} Though if id is unsigned, is_int($id) might be better.

In81Vad0 · Accepted Answer · 2010-09-26 11:56:29Z

1

why don't you join firstname and lastname in the sql?

$query = mysql_query("SELECT concat(firstname, ' ',lastname) as 'Name' FROM users WHERE id = $id");

normally this should also work

$query = mysql_query("SELECT firstname + ' ' + lastname as 'Name' FROM users WHERE id = $id");

answered Sep 26, 2010 at 11:56

In81Vad0

1296 bronze badges

Collectives™ on Stack Overflow

PHP: make a function

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related