A javascript Object ambiguous problem

Question

this is a very very strange problem...

see this code:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" lang="zh-CN">
<head>
<title>TEST</title>
<script src="http://misc.fandongxi.com/js/jquery.1.4.js" type="text/javascript"></script>
</head>
<body>

<a href="#" id="p1">click this to change p1.x</a>
<a href="#" id="p2">click this to change p2.x</a>

<input id="p1_val" value="">
<input id="p2_val" value="">

<script language="JavaScript">

a = function(id) {

    this.inputid = id+'_val';
    othis = this;
    $('#'+id).click(function(){
        othis.x += 1;
        $('#'+othis.inputid).val(othis.x);
    });

}


p1 = new a('p1');
p1.x=1;
p2 = new a('p2');
p2.x=1;

</script>


</body>
</html>

i wanna click the ID "p1" to make p1.x add 1,and Click the "P2" to make p2.x add 1

but

the problem is click any of them...the p2.x will add 1

waiting for answer....

very thank you:)

i am not good at english....maybe i don't make the problem clearly;

Nick Craver · Accepted Answer · 2010-09-27 18:32:13Z

3

I'm not really sure what you're overall goal is, but the error you're asking about is here:

othis = this;

It should be declared with var:

var othis = this;

Currently there's only one othis being shared, since it's a global variable when used without the var keyword before it.

You can see the updated/working version here.

answered Sep 27, 2010 at 18:32

Nick Craver

631k138 gold badges1.3k silver badges1.2k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Greg · Accepted Answer · 2010-09-27 18:32:13Z

2

You need to scope othis to the function. Currently it is used as a global variable.

var othis = this;

answered Sep 27, 2010 at 18:32

Greg

23.4k11 gold badges61 silver badges80 bronze badges

Collectives™ on Stack Overflow

A javascript Object ambiguous problem

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related