Yii2 multiple models loop save error

Question

I've a table in which I have to save multiple data, in my controller I've implemented this action:

public function actionUpdateOrder($id){
    /*DA TESTARE*/
    //$result = 0;
    $result = true;
    $s = new Session;
    $model = new SlidersImages();
    if ($new_order = Yii::$app->request->post('order')) {
        //$s['us_model'] = 0;
        foreach ($new_order as $key => $value) {
            if ($model::find()->where(['slider_id' => $id, 'image_id' => $key])->all()) {
                 $s['image_'.$key] = $model;

                $model->display_order = $value;
                //$result = ($t = $model->update()) ? $result + $t : $result;
                $result = $model->save() && $result;
            }
        }
    }

    return $result;
}

The data received are right but not the result, the only thing that the action do is to add new table row with slider_id and image_id equal to NULL, why the model doesn't save correctly?

Thanks

Ruslan Bes · Accepted Answer · 2016-06-29 11:04:34Z

0

The thing is when you call

$model::find()->where(['slider_id' => $id, 'image_id' => $key])->all()

you don't change the $model object itself. Essentially you are calling:

SlidersImages::find()->where(['slider_id' => $id, 'image_id' => $key])->all()

So, later when you call $model->save() you are saving a $model object with empty attributes (you only changed display_order)

My advise here: try to assign the result of the ->all() call to the new var and then work with it:

public function actionUpdateOrder($id){
    /*DA TESTARE*/
    //$result = 0;
    $result = true;
    $s = new Session;
    if ($new_order = Yii::$app->request->post('order')) {
        //$s['us_model'] = 0;
        foreach ($new_order as $key => $value) {
            $models = SliderImages::find()->where(['slider_id' => $id, 'image_id' => $key])->all();
            if (count($models)) {
                // loop through $models and update them
            }
        }
    }

    return $result;

edited Jun 29, 2016 at 11:04

answered Jun 29, 2016 at 10:41

Ruslan Bes

2,7452 gold badges27 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

MarBer Over a year ago

Thanks @Ruslan Bes for the answer, the final solution I've adopted using your suggestion is as follows:

if ($model = SlidersImages::findOne(['slider_id' => $id, 'image_id' => $key])) {                                         $model->display_order = $value;                     //$result = ($t = $model->update()) ? $result + $t : $result;                     $result = $model->save() && $result;                 }

Collectives™ on Stack Overflow

Yii2 multiple models loop save error

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related