C# Access Db update query not working

Question

I am trying to update an access table with the code noted below. however, the update does not execute. It doesn't give me any errors but it doesn't update the database. Any suggestions?

string Const = @"Provider=Microsoft.ACE.OLEDB.12.0;Data Source=F:\\Db\\test.accdb";      

OleDbCommand Cmd;
OleDbConnection con22 = new OleDbConnection(Const );
con22.Open();

string sql = "UPDATE CostT SET tFormSent='" + Selection1.Text + "',TName='" + UserName.Text + "',FormDate='" + FormDate.Text + "',where ReqNum=" + ReqNum.Text;

cmd = new OleDbCommand(sql, con22);
cmd.ExecuteNonQuery();
con22.Close();

MessageBox.Show("Form has been Updated");

It should be throwing an error, since there's at least one syntax error. Though given all these SQL injection vulnerabilities, there's no telling what random code you might be executing on your database. What's the actual runtime value of the query you're executing? — David
– David, Commented Jun 30, 2016 at 12:17

NikhilSN · Accepted Answer · 2016-06-30 12:34:34Z

5

Try changing the query
to

string sql = "UPDATE CostT SET tFormSent = @selection1,TName = @UserName,FormDate = @FormDate where ReqNum = @ReqNum";
cmd = new OleDbCommand(sql, con22);
cmd.Parameters.Add("@selection1", Selection1.Text);
cmd.Parameters.Add("@UserName", UserName.Text);
cmd.Parameters.Add("@FromDate", FromDate.Text);
cmd.Parameters.Add("@ReqNum", ReqNum.Text);
cmd.ExecuteNonQuery();
con22.Close();

answered Jun 30, 2016 at 12:34

NikhilSN

1073 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

hex c Over a year ago

This is perfect!! I think the SQL injections i had messed everything up. But the parameters version worked perfectly. Now i just have to learn Unions and Delete. Thank you!!

René Vogt · Accepted Answer · 2016-06-30 12:18:48Z

4

Your query has a syntax error: you have a comma before your WHERE clause that does not belong there.

But more important: Your code is open to SQL injection! Please don't insert user input directly into your query, but use parameterized queries instead!

answered Jun 30, 2016 at 12:18

René Vogt

44.1k15 gold badges84 silver badges106 bronze badges

Collectives™ on Stack Overflow

C# Access Db update query not working

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related