sharing data between controllers, ionic + angular js

Question

these are my controllers:

.controller('recommendedJobsCtrl', function($q,$scope, $ionicSideMenuDelegate,$window,$http,dataShare) {
    $scope.text='hey world';
    $scope.post=function(){
      dataShare.sendData($scope.text);
       console.log('sent: ' + $scope.text);
    }   
 })
.controller('jobsCtrl', function($scope,dataShare) {
   $scope.words=dataShare.getData();
})

and this is my factory:

.factory('dataShare',function($rootScope){
  var service = {};

    service.sendData = function(data){
      service=data;
      $rootScope.$broadcast('data_shared', service);
     },

    service.getData = function(){
      console.log('this.data is ' + service)
      return service;

    };
  return service;
});

when the console.log prints, service is empty. How do i fix this ?

Suneet Bansal · Accepted Answer · 2016-07-10 04:27:50Z

2

Factory code is not written correctly and also you should use angular service instead of creating factory since you have to only share data between controllers. Although both are singleton objects.

Lets do it with factory first

.factory('dataShare',function(){
  var service = {
     sendData: sendData,
     getData: getData
  };

  var serviceData;

  function sendData(data){
      serviceData = data;
  }

  function getData(){
      console.log('this.data is ' + serviceData);
      return serviceData;
  }

  return service;
});

Lets do it with service

.service('dataShare',function(){
  var serviceData;

  this.sendData = function(data){
      serviceData = data;
  }

  this.getData = function(){
      console.log('this.data is ' + serviceData);
      return serviceData;
  }
});

answered Jul 10, 2016 at 4:27

Suneet Bansal

2,7061 gold badge16 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Arun Ghosh · Accepted Answer · 2016-07-10 04:15:02Z

0

To receive data you need to :

$rootScope.$on('data_shared', function(evt, data) {
});

It is async operation, so you cannot invoke it synchronously. If you want to abstract the communication, you need to implement you own observer/subscriber pattern.

edited Jul 10, 2016 at 4:15

answered Jul 10, 2016 at 3:55

Arun Ghosh

7,7741 gold badge28 silver badges38 bronze badges

1 Comment

noor h Over a year ago

this issue is when the console.log in my .factory returns an empty {}.

Collectives™ on Stack Overflow

sharing data between controllers, ionic + angular js

2 Answers 2

Lets do it with factory first

Lets do it with service

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Lets do it with factory first

Lets do it with service

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related