Update table values using cmd.Parameters.AddWithValue not working

Question

I have to update some values in table row if UserId = Session["username"] but its showing error:

ExecuteNonQuery: Connection property has not been initialized.

can any one know what i am doing wrong here a Session["username"] have its value i have checked.

SqlConnection conn7 = new SqlConnection(@"Data Source=SANJAY-PC\SQLEXPRESS;Initial Catalog=dev;User ID=sa;Password=sa@123;Pooling=False");
        var qry = "UPDATE Registration (FirstName,LastName,Password,LastName,EmaildId,UserId) " +
      "VALUES (@FirstName, @LastName, @Password, @EmaildId, @UserId) WHERE UserId='" + Session["username"] + "'";
        var cmd = new SqlCommand(qry);
        cmd.Parameters.AddWithValue("@FirstName", Firstname_Update.Text);
        cmd.Parameters.AddWithValue("@LastName", Lastname_Update.Text);
        cmd.Parameters.AddWithValue("@Password", Password_Update.Text);
        cmd.Parameters.AddWithValue("@EmaildId", EmailIdUpdate.Text);
        cmd.Parameters.AddWithValue("@UserId", UserIdUpdate.Text);
        conn7.Open();
        cmd.ExecuteNonQuery();
        conn7.Close();

Why do you use parameters for all of them except UserId ?

Zein Makki
– Zein Makki

2016-07-11 07:13:47 +00:00
Commented Jul 11, 2016 at 7:13 — Zein Makki
– Zein Makki, Commented Jul 11, 2016 at 7:13
@SanjayNakate check my answer

Sachu
– Sachu

2016-07-11 07:46:08 +00:00
Commented Jul 11, 2016 at 7:46 — Sachu
– Sachu, Commented Jul 11, 2016 at 7:46

Esko · Accepted Answer · 2016-07-11 07:13:48Z

2

You need to tell the SqlCommand-object which connection to use, change this line

var cmd = new SqlCommand(qry, conn7);

answered Jul 11, 2016 at 7:13

Esko

4,2172 gold badges26 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Sanjay Nakate Over a year ago

i have added this but its showing Incorrect syntax near '('. at cmd.ExecuteNonQuery(); line

Esko Over a year ago

@SanjayNakate you must have syntax error somewhere, did you change that line? Check the code again.

Sachu · Accepted Answer · 2016-07-11 07:45:51Z

1

Two Problems

In SQLCOMMAND you should specify querystring,connection
Your update query syntax is wrong

..try below

SqlConnection conn7 = new SqlConnection(@"Data Source=SANJAY-PC\SQLEXPRESS;Initial Catalog=dev;User ID=sa;Password=sa@123;Pooling=False");

var qry = "UPDATE Registration   
           SET FirstName=@FirstName,LastName=@LastName,Password=@Password,
            EmaildId=@EmaildId,UserId=@UserId WHERE UserId=@UserId1";
            var cmd = new SqlCommand(qry,conn7);
            cmd.Parameters.AddWithValue("@FirstName", Firstname_Update.Text);
            cmd.Parameters.AddWithValue("@LastName", Lastname_Update.Text);
            cmd.Parameters.AddWithValue("@Password", Password_Update.Text);
            cmd.Parameters.AddWithValue("@EmaildId", EmailIdUpdate.Text);
            cmd.Parameters.AddWithValue("@UserId", UserIdUpdate.Text);
    cmd.Parameters.AddWithValue("@UserId1",  Session["username"].ToString());
            conn7.Open();
           // cmd7.ExecuteNonQuery();
            cmd.ExecuteNonQuery();
            conn7.Close();

edited Jul 11, 2016 at 7:45

answered Jul 11, 2016 at 7:23

Sachu

7,7549 gold badges59 silver badges101 bronze badges

1 Comment

Jeremy Thompson Over a year ago

SET is missing in the sql

Zein Makki · Accepted Answer · 2016-07-11 07:43:54Z

0

Use Parameters for all you input, don't concatenate strings in queries.

As for your error, you need to specify the connection that the command needs to use:

SqlConnection conn7 = new SqlConnection(@"Data Source=SANJAY-PC\SQLEXPRESS;
                           Initial Catalog=dev;User ID=sa;Password=sa@123;Pooling=False");

var qry = " UPDATE Registration SET FirstName = @FirstName, LastName = @LastName," 
        + " Password = @Password, EmaildId = @EmaildId WHERE UserId = @UserCondition";

var cmd = new SqlCommand(qry, conn7 );

cmd.Parameters.AddWithValue("@FirstName", Firstname_Update.Text);
cmd.Parameters.AddWithValue("@LastName", Lastname_Update.Text);
cmd.Parameters.AddWithValue("@Password", Password_Update.Text);
cmd.Parameters.AddWithValue("@EmaildId", EmailIdUpdate.Text);
cmd.Parameters.AddWithValue("@UserId", UserIdUpdate.Text);
cmd.Parameters.AddWithValue("@UserCondition", Session["username"].ToString());
conn7.Open();

cmd.ExecuteNonQuery();

conn7.Close();

edited Jul 11, 2016 at 7:43

answered Jul 11, 2016 at 7:17

Zein Makki

30.2k6 gold badges58 silver badges66 bronze badges

5 Comments

Sanjay Nakate Over a year ago

i have added this but its showing Incorrect syntax near '('. at cmd.ExecuteNonQuery(); line

Zein Makki Over a year ago

@SanjayNakate You update syntax is wrong. check the edited answer.

Sanjay Nakate Over a year ago

Code compile without any errors but values not going to update.

Zein Makki Over a year ago

@SanjayNakate Why are you using UserIdUpdate.Text is one place and Session["username"] in another place. Change the update query provided to meet your needs, but keep the same UPDATE syntax.

Sanjay Nakate Over a year ago

Let us continue this discussion in chat.

return true · Accepted Answer · 2016-07-11 07:54:08Z

-1

UPDATE table_name
SET column1=value1,column2=value2,...
WHERE some_column=some_value;
'Set' Missing

edited Jul 11, 2016 at 7:54

return true

7,9262 gold badges22 silver badges37 bronze badges

answered Jul 11, 2016 at 7:26

kattav mauk

665 bronze badges

Collectives™ on Stack Overflow

Update table values using cmd.Parameters.AddWithValue not working

4 Answers 4

2 Comments

1 Comment

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

1 Comment

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related