Rails View Helper Not Inserting HTML into Page

Question

I'm having an issue using a custom helper method in my Rails (3.0) app to output the required html.

I have the following call in my partial view: _label.html.erb

<% display_resource "Diamond", @resource.diamond %>

And in the resource_helper.rb file:

module ResourceHelper
   def display_resource(display_name, value)
      "<tr><td>#{display_name} </td><td>#{value.to_s}%</td></tr>" if value > 0
   end
end

The intended output is:

<tr>
  <td>Diamond</td>
  <td>15%</td>
<tr>

*granted, without the formatting, and the 15 is arbitrary

If I use the <%= ... %> when performing the method call, it'll output the string correctly, but it won't be html (ie I'll see "<tr><td>Diamond </td><td>15%</td></tr>" as opposed to "Diamond 15%")

What am I doing incorrectly?

Main reason why it isn't printing is because you use <% %> instead of <%= %> — klew
– klew, Commented Sep 30, 2010 at 14:28
If I used <%=...%> it'd output the string, but it would be the actual string (as that's the default behavior of rails now - to prevent XSS and other type of security holes that could arise) — MunkiPhD
– MunkiPhD, Commented Sep 30, 2010 at 15:00

geermc4 · Accepted Answer · 2013-01-18 01:00:01Z

10

You need to mark the string returned as "raw" and then use <%= %>

module ResourceHelper
   def display_resource(display_name, value)
      raw("<tr><td>#{display_name} </td><td>#{value.to_s}%</td></tr>") if value > 0 # string wrapped in raw
   end
end

edited Jan 18, 2013 at 1:00

geermc4

5786 silver badges19 bronze badges

answered Sep 30, 2010 at 14:23

Rob Di Marco

45.3k9 gold badges73 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Robbie Over a year ago

I just migrated an app to Rails 3, and I'd like to ask: this is a new behavior in how Rails 3 treats HTML Safe strings, correct?

MunkiPhD Over a year ago

@Robbie - I believe so - thus why I had this issue (but didn't know how to rectify it. Thanks for the help Rob!

danengle Over a year ago

Yes, this is the new way rails renders text. By default, all text rendered between <%= .. %> is escaped and you need to use raw() if you have some html that needs to be displayed

Darth Egregious Over a year ago

Your smart and I appreciate your help.

Collectives™ on Stack Overflow

Rails View Helper Not Inserting HTML into Page

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related