javascript do shell script

Question

Newbee question -

Now that OSX/Script Editor.app can do javascript, how do I change my applescript set a to (do shell script "ls") to the javascript syntax?

From what I'm reading in the StandardAdditions.sdef, "doShellScript method : Execute a shell script using the ‘sh’ shell" is the command, so I tried, doShellScript "ls" , and the Script Editor (with the Script Language is set to JavaScript) returns,

"Error -2700: Script error."

ShooTerKo · Accepted Answer · 2016-07-15 06:43:53Z

4

You have to tell your JXA script to use the Standard Additions.

app = Application.currentApplication()
app.includeStandardAdditions = true

sourcePath = "/Applications"

// Do not use! Unsafe path-quoting can lead to injection and unwanted behavior! See the update below for the safe version!
app.doShellScript("ls '" + sourcePath + "'").split("\r")

UPDATE: EDIT After being slapped on the hand by @foo for using a fairly unsafe path-quoting method, the new answer is this:

app = Application.currentApplication()
app.includeStandardAdditions = true

sourcePath = "/Applications"

// Safe version!
app.doShellScript("ls '" + sourcePath.replace("'", "'\\''") + "'")

Enjoy, Michael / Hamburg

edited Jul 15, 2016 at 6:43

answered Jul 14, 2016 at 14:53

ShooTerKo

2,3021 gold badge16 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

SeniorInquisitor Over a year ago

That did it. Thank you.

foo Over a year ago

@Shoo: Your example is dangerously unsafe! What happens if sourcePath contains a single quote mark, e.g. "/Users/jsmith/Bob's stuff"? You must sanitize your inputs when munging them into a new shell script, e.g. doShellScript("ls '" + sourcePath.replace("'", "'\\''") + "'"). If you don't, at best your shell script will fail to run; at worst it will do totally the wrong thing. For example, what if you'd been using rm -rf instead? Gods help you if you had another folder named "Bob" on there full of important files, 'cos—Surprise!—now you don't. Always sanitize, sanitize, sanitize!

ShooTerKo Over a year ago

@foo: Yes, of course you are right, thank you! My fast written solution just scoped the doShellScript, but we as community should take care when answering, especially for Newbies or even for Newbies that will read the answer later! I'll update my answer.

ShooTerKo Over a year ago

@CRGreen I quoted you. Your answer being slapped on the hand just hit the point :-D

Collectives™ on Stack Overflow

javascript do shell script

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related