MVC Custom Authorize Attribute From Database

Question

I made my own custom Role table in my database and I wanted to also create a custom authorize attribute along with it.

Here is what I have so far, but I'm not really sure how to proceed:

    private List<RoleModel> Roles;
    private IRoleRepository repo;
    private ICustomerRepository cust;


    public bool CheckRoles(string UserId)
    {
        try
        {
            Roles = repo.GetAll().ToList();
            CustomerModel Customer = cust.Get(UserId);
            int CustomerRole = Customer.RoleId;
            RoleModel role = Roles.First(x => x.id == CustomerRole);


        }
        catch(Exception e)
        {
            return false;
        }
    }

    public override void OnAuthorization(AuthorizationContext filterContext)
    {
        base.OnAuthorization(filterContext);
        string UserId = filterContext.HttpContext.User.Identity.GetUserId();



    }

If anyone can help me finish this I would greatly appreciate it.

Thanks!

which part you are stuck, can you elaborate?

Ehsan Sajjad
– Ehsan Sajjad

2016-07-17 21:55:03 +00:00
Commented Jul 17, 2016 at 21:55 — Ehsan Sajjad
– Ehsan Sajjad, Commented Jul 17, 2016 at 21:55

gentiane · Accepted Answer · 2016-07-18 11:55:14Z

1

I think that create a custom AuthorizeAttribute is not a good idea. It is a good practice to use the standard AuthorizeAttribute.

It is a common case to have its own Role table. It is better to override how to set the roles of the identity of your principal and to use the Roles property of AuthorizeAttribute. Set the role as a claim once when the user is logging; it will be better than retrieve the role from database in the custom Authorize attribute at each request. Set your claim CalimTypes.Role, and then protect your controllers/actions with :

[Authorize(Roles = "admin")]

answered Jul 18, 2016 at 11:55

gentiane

6,8653 gold badges25 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Shadow1349 Over a year ago

The reason that I made my own role table is because you have to buy a role so each role has a price column along with it and the default doesn't have that. However, do you think it would be good practice to give my role table a foreign key of ASPRoleId and link to it that way?

Collectives™ on Stack Overflow

MVC Custom Authorize Attribute From Database

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related