Combining array of strings into one string

Question

I have the following array of strings:

array = [id, message, date, length]

Example:

array = ["1", "test's message", "2016-01-01", "15"]

I want to merge it into one string. I will use that string to insert data in DB using:

ActiveRecord::Base.connection.execute

I did:

result = "(#{array[0}', '#{array[1]}', '#{array[2]}', '#{array[3]}')"

message contains special characters ' (ASCII code 039). This results in SQL exception. How can I construct a result string that includes the ' character?

EDIT:

To put data in BD I use:

conn = ActiveRecord::Base.connection
sql = "INSERT INTO table_name (`id`, `message`, `date`, `length`) VALUES #{result}"
  conn.execute sql

EDIT:

I fixed this using AR method:

ActiveRecord::Base.connection.quote(message)

You are doing it wrong. There is 2016 around an no one sane developer would construct SQL by joining strings. — Aleksei Matiushkin
– Aleksei Matiushkin, Commented Jul 18, 2016 at 7:18
At which point is the exception raised? During loading the file? During generation of the string? During SQL query? — sawa
– sawa, Commented Jul 18, 2016 at 7:19
You are doing it wrong. There is 2016 around an no one sane developer would construct SQL by joining strings. Why? I need performance. I want to put data in DB using raw SQL. I don't need AR because I have validated data and I am not scared about Dependency injection because it is simple backgroud job. Tell my why. I have huge amount of data and using plain sql increases inserting 20x — dewastator
– dewastator, Commented Jul 18, 2016 at 7:20
At which point is the exception raised? During loading the file? During generation of the string? During SQL query? exception is rised because I have ' char in message string. This is why I am asking how merge strings with special characters. You don't need exception message. — dewastator
– dewastator, Commented Jul 18, 2016 at 7:23
Cannot be reproduced. The error is not raised because there is a ' in the message string. — sawa
– sawa, Commented Jul 18, 2016 at 7:24

Community · Accepted Answer · 2017-05-23 12:32:39Z

2

answer is here:

How to insert a value that contains an apostrophe (single quote)?

You basically double up the apostrophe: "test''s message"

edited May 23, 2017 at 12:32

CommunityBot

11 silver badge

answered Jul 18, 2016 at 7:35

seph

6,0963 gold badges23 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Lukas Baliak · Accepted Answer · 2016-07-18 08:24:39Z

1

You can use this code for generate result.

array = ["1", "test's message", "2016-01-01", "15"]

result = "(#{array.map{|s| s.gsub!("'", "''"); "'#{s}'"}.join(",")})"
# => => "('1','test''s message','2016-01-01','15')"

answered Jul 18, 2016 at 8:24

Lukas Baliak

2,8792 gold badges26 silver badges26 bronze badges

Comments

Awais Shafqat · Accepted Answer · 2016-07-18 07:55:05Z

0

You need to escape the special character like this

array = ["1", "test''s message", "2016-01-01", "15"]

answered Jul 18, 2016 at 7:55

Awais Shafqat

5466 silver badges13 bronze badges

Comments

spidergears · Accepted Answer · 2016-07-18 07:18:02Z

-2

Use Array#join Doc Link

arr = [id, message, data, length]
join_result = arr.join(',')

answered Jul 18, 2016 at 7:18

spidergears

1941 silver badge11 bronze badges

Collectives™ on Stack Overflow

Combining array of strings into one string

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related