bash - PUT data with curl with variables from file

Question

I have a bash script like this

#!/bin/bash

while read fqdn hostname; do
curl -H "Content-Type:application/json" -XPUT "https://server/api/hosts/${fqdn}" -d '{"host":{"name": "'${hostname}'"}}' --cacert bundle.pem --cert pnet-pem.cer --key privkey.pem
done <curl1.txt

The file curl1.txt contains of

fqdn (tab)hostname

..........

I have to update some data using theForeman API. I have a lot fqdns and hostnames so I've wrote the script above. The problem is with JSON, because I get an error like this:

{"status":400,"error":"There was a problem in the JSON you submitted: 795: unexpected token at '{\"host\":{\"name\": \"ptesrv02-lub\r\"}}'"}

When I put '{"host":{"name": "${hostname}"}}' instead '{"host":{"name": "'${hostname}'"}}' I get

{
  "error": {"id":130,"errors":{"interfaces.name":["is invalid"],"name":["is invalid"]},"full_messages":["Name is invalid","Name is invalid"]}
}

So where is the problem? Can You help me with that?

You've a trailing \r character in your ${hostname} value: ptesrv02-lub\r . This is very likely to be the issue. — pah
– pah, Commented Jul 20, 2016 at 8:34
Ok, so what means \r ? In text file I have no sign like this and the file is generated by ruby script. — ala Smith
– ala Smith, Commented Jul 20, 2016 at 8:36
@Inian since you were the first one to present a working solution, please put your comment as an answer so OP can accept it. — pah
– pah, Commented Jul 20, 2016 at 9:15
@salih You should also provide your answer as it is an alternate and helpful method. — pah
– pah, Commented Jul 20, 2016 at 9:16
@alaSmith: You can click on the small tick-mark on the left of the answer below for accepting the post, thereby marking the post as solved. — Inian
– Inian, Commented Jul 20, 2016 at 9:22

Community · Accepted Answer · 2017-05-23 12:08:17Z

1

To remove trivial special characters from files copied from Windows(CR-LF endings) 'tr' command can be used as

hostname=$(echo $hostname|tr -d '\r')

in your example above. Presence of these special characters mangles how bash treats characters.

Credits to threadp for pointing out the presence of special characters in the hostname variable.

If you ever suspect the file to have such CR-LF endings, you can confirm by searching for them by using grep, treating the file as binary

grep -U $'\015' curl1.txt

edited May 23, 2017 at 12:08

CommunityBot

11 silver badge

answered Jul 20, 2016 at 9:20

Inian

87k15 gold badges166 silver badges183 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Community · Accepted Answer · 2017-05-23 11:52:52Z

1

As threadp pointed, you have a trailing \r character. You can try this to remove it.

${hostname%?}

This usage just remove last character, in this scenario, it was trailing \r. But, it is better to use

${hostname/$'\r'/}

Thanks 123

edited May 23, 2017 at 11:52

CommunityBot

11 silver badge

answered Jul 20, 2016 at 9:30

sozkul

6754 silver badges10 bronze badges

1 Comment

123 Over a year ago

That will just remove the last character, better to use something like "${hostname/$'\r'/}"

Collectives™ on Stack Overflow

bash - PUT data with curl with variables from file

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related