Removing zero values from an array of objects

Question

Problem

I'm pushing values from my JavaScript functions and filling an array with objects. what I would like to happen is remove key + Value pairs that are zero.

example of return array

[Object percent: 516 unit: -10.689124404913258
 Object percent: 516  unit: -9.011227255423254
 Object percent: 561  unit: -12.669770888525518
 Object percent: 6516 unit: -15.99180968320506 
 Object percent: 0  unit: 0]

JavaScript

my_arr = []

  for(var i = my_arr.length - 1; i >= 0; i--) {
    if(array[i] === 0) {
       array.splice(i, 1);
    }
   return my_arr;
}

Just update the if condition from array[i] === 0 to array[i]['percent'] === 0 || array[i]['unit'] === 0. Change the || to && if both properties should be 0 for the object to be removed. — 10100111001
– 10100111001, Commented Jul 20, 2016 at 20:03

Morteza Tourani · Accepted Answer · 2016-07-20 20:17:28Z

3

If you want to remove items from your array which has price and unit you can use this.

var items = [
    { percent: 516, unit: -10.689124404913258 }, 
    { percent: 516, unit: -9.011227255423254 }, 
    { percent: 561, unit: -12.669770888525518 }, 
    { percent: 6516, unit: -15.99180968320506 }, 
    { percent: 0, unit: 0 }
];

items = items.filter(i => i.percent && i.unit);

console.log(items);

BTW the main problem with yours is that you return inside the loop which will stop the loop in the very first turn. I don't even believe that your code works even for a while because using return out side the function scope i kind of error:

Uncaught SyntaxError: Illegal return statement

edited Jul 20, 2016 at 20:17

answered Jul 20, 2016 at 20:05

Morteza Tourani

3,5665 gold badges44 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

nem035 Over a year ago

this would filter out all falsy values, but OP specifically said only 0s.

Morteza Tourani Over a year ago

@nem035 Your right but OP's example is about to deal with numbers.

C. Kelly Over a year ago

@mortezaT Love your approach, whoever I getting a Syntax error in IE any thoughts on how to get over this currently your solution is written like this $('#sub').click(function() { items = my_arr.filter(i => i.percent && i.unit); console.log(items); })

Morteza Tourani Over a year ago

@C.Kelly I think this is because IE is not supporting ES6. Just change the lamda (i => i.percent && i.unit) with an anonymous function (function(i){ return i.percent && i.unit; })

hsz · Accepted Answer · 2016-07-20 20:03:20Z

2

Just try with:

my_arr.filter(function(element){
  return element.percent && element.unit;
});

If percent and unit properties equal 0, it will give false result and will be filtered out from the results.

answered Jul 20, 2016 at 20:03

hsz

153k63 gold badges268 silver badges320 bronze badges

Comments

Steve Greatrex · Accepted Answer · 2016-07-20 20:04:25Z

2

Assuming your source array looks like this...

var sourceArray = [
    { percent: 123, unit: -1 },
    { percent: 456, unit: -2 },
    { percent: 0, unit: 0 },
    { percent: 789, unit: -3 }
];

....then you can get a filtered array using the Array.prototype.filter function:

var filteredArray = sourceArray.filter(function(item) {
    return item.percent || item.unit;
})
// => [
//  { percent: 123, unit: -1 },
//  { percent: 456, unit: -2 },
//  { percent: 789, unit: -3 }
//];

Note that this is checking that both percent and unit are zero before removing the item. If you only need to check one of the values then you can modify the filter function (e.g. return item.percent if you only want to check percent)

answered Jul 20, 2016 at 20:04

Steve Greatrex

16k5 gold badges62 silver badges74 bronze badges

6 Comments

nem035 Over a year ago

You want &&, not || :)

Steve Greatrex Over a year ago

@nem035 && would filter out items where either percent or unit is falsey. As per my edit, this only filters items where both percent and unit are zero. Not clear what OP was asking for!

nem035 Over a year ago

OP said > "what I would like to happen is remove key + Value pairs that are zero", so that seems like both to me :). You got my upvote regardless though, its a correct approach

Steve Greatrex Over a year ago

Exactly. Not "where percent is zero" nor "where unit is zero". "That are zero" could be inferred to mean "where both are zero", "where either is zero" or where "one specific value is zero". Based on his sample data I assumed he meant "where both are zero"

C. Kelly Over a year ago

My apologies if I wasn't clear, it doesn't have to be both just whichever returns zero

|

moopet · Accepted Answer · 2016-07-20 20:05:06Z

1

You can just use a filter:

var filtered_array = my_arr.filter(function(el) { return el.percent > 0; });

of course you can include whatever other conditions you like - the filtered array contains all the elements where the callback function returns true.

answered Jul 20, 2016 at 20:05

moopet

6,1761 gold badge31 silver badges38 bronze badges

1 Comment

C. Kelly Over a year ago

filtered_array is returning an empty array?

Collectives™ on Stack Overflow

Removing zero values from an array of objects

4 Answers 4

4 Comments

Comments

6 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

Comments

6 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related