Using a loop to simplify preg_replace

Question

Am I able to simplify this code? I am getting five strings from a SELECT query, stripping them down to only numbers and adding them.

$sum = preg_replace("/[^0-9]/","",$row['AB']) + preg_replace("/[^0-9]/","",$row['CD']) + preg_replace("/[^0-9]/","",$row['EF']) + preg_replace("/[^0-9]/","",$row['GH']) + preg_replace("/[^0-9]/","",$row['IJ']);

Can I do something like this:

preg_replace("/[^0-9]/","",$sum = $row['AB'] + $row['CD'] + $row['EF'] + $row['GH'] + $row['IJ']);

Steve · Accepted Answer · 2016-07-22 11:28:05Z

1

You can write a simple loop to reduce code duplication:

Provided your sql only selects the required columns:

$sum = 0;
foreach($row as $item)
    $sum += preg_replace("/[^0-9]/","",$item);

If you have more columns in the row (and you actually need that data so you cant just alter the SQL):

$sum = 0;
foreach(['AB','CD','EF','GH','IJ'] as $key)
    $sum += preg_replace("/[^0-9]/","",$row[$key]);

edited Jul 22, 2016 at 11:28

answered Jul 22, 2016 at 11:25

Steve

20.5k5 gold badges47 silver badges71 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

The Codesee Over a year ago

Wow, thanks! I'll accept your answer when the wait is up :)

Steve Over a year ago

No problem. As a side note, if you have to run the code frequantly (eg not just a weekly report of something) then i would refactor the database to include the required data in integar columns, so you can do the math in SQL its self

Collectives™ on Stack Overflow

Using a loop to simplify preg_replace

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related