Am i creating a nil object? (undefined method ___ for nil:NilClass) error - ruby on rails

Question

My validations were working for a while, or so I thought. Now I come back to them after a while doing something else and I am getting the error above. I think it means I am creating a nil object with the .new method but I am just lost. It seemed to be a problem with the creation of a new object by the controller because even if I # out the validation the next validation in the tree on another attribute of @thing throws up the same error. However even if I create the object in the console and test it's there the .save method throws up the error still - undefined method 'user_id' for nil:NilClass

ThingsController:

def create
  @thing = Thing.new(params[:thing])
  @thing.user_id = @currentuser_id

  if @thing.save
    flash[:notice] = "Successfully created thing."
    redirect_to @thing
  else
    #flash[:notice] = "Your thing did not get created."
    render 'otherthings/show'      
  end
end

Thing.rb
  validate :user_valid
  def user_valid
    errors.add("you must be logged in to add a thing") unless @thing.user_id?
  end

I'm a bit of a ruby on rails noob (i.e. <8weeks) and this is my first stackoverflow question, so go easy on me if this is stupidly obvious. I've tried params["thing"] too, as that worked in the console after manually creating params to match the log files (whereas params [:thing] didn't) but that doesn't change anything in terms of the error message I get.

the error was popped up referring to the controller call on thing.save and then on the model line starting errors.add ...but i think the guys below answered for me :-) — Richard Jordan
– Richard Jordan, Commented Oct 4, 2010 at 22:55

theIV · Accepted Answer · 2010-10-04 22:34:54Z

2

When you are calling unless @thing.user_id?, it's flipping out because there's no @thing (it doesn't get passed from your controller to your model as an instance variable).

I don't remember how exactly it works, but I'm pretty sure that when calling validate :user_valid, it will pass along the record to be validated for you. If that's indeed the case you could try:

def user_valid
  errors.add("you must be logged in to add a thing") unless user_id?
end

edited Oct 4, 2010 at 22:34

answered Oct 4, 2010 at 22:28

theIV

25.9k5 gold badges56 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Garrett Over a year ago

If he is already in the Thing model he should be able to use user_id? or user.present? (if it's an association)

theIV Over a year ago

Thanks, I realized that afterwards. I'll fully update the answer to reflect that.

Richard Jordan Over a year ago

Thanks - you guys are really helpful... this certainly seemed to fix the problem with user_id and I think I probably have some similar issues with other validations I should be able to figure out through some trial and error after digesting your brief simple explanation.

Collectives™ on Stack Overflow

Am i creating a nil object? (undefined method ___ for nil:NilClass) error - ruby on rails

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related