Adding element to an array while iterating over it

Question

I have a for loop that loops over each element in an array. Under a certain condition, I add another element to that array inside the loop. However, the loop doesn't take that new element into account. If there are 6 items originally in the array and while looping through, I add 2 more, it still only loops 6 times. How can I fix this?

for ingredient in ingredientList {
    if ingredient.name == "banana" {
        var orange = Ingredient(name: "orange")
        ingredientList.append(orange)
    }
    if ingredient.name == "orange" {
        // this never executes
    }
}

If one of my ingredients is a banana, add an orange to the list. However, the loop never even considers the newly added element. How can I accomplish something like this and why doesn't it work?

Kubba · Accepted Answer · 2016-07-26 21:07:37Z

3

try this:

var array = ["a", "b"]

for i in array.startIndex...array.endIndex {
    if array[i] == "b" {
        array.append("c")
        print("add c")
    }
    if array[i] == "c"{
        array.append("d")
        print("add d")
    }
}

answered Jul 26, 2016 at 21:07

Kubba

3,42823 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

idmean Over a year ago

This answer is very bad. See stackoverflow.com/a/44823937/1779477 for better solutions.

user8554794 · Accepted Answer · 2017-11-18 15:30:40Z

1

@ghostatron A collection’s indices property can hold a strong reference to the collection itself, causing the collection to be non-uniquely referenced. If you mutate the collection while iterating over its indices, a strong reference can cause an unexpected copy of the collection. To avoid the unexpected copy, use the index(after:) method starting with startIndex to produce indices instead.

var c = MyFancyCollection([10, 20, 30, 40, 50])
var i = c.startIndex
while i != c.endIndex {
    c[i] /= 5
    i = c.index(after: i)
}
 // c == MyFancyCollection([2, 4, 6, 8, 10])

answered Nov 18, 2017 at 15:30

user8554794

Comments

ghostatron · Accepted Answer · 2016-07-26 21:14:13Z

0

I think there are two issues here:

Generally speaking, you shouldn't modify a collection while enumerating it. At best, it will ignore you. In most languages it will just crash.
I suspect what you are seeing here, is that your loop is working with a copy of the collection, but your "append" is modifying the original. My reasoning there is that in Swift, structs are typically copies rather than references, and freakishly enough...arrays and dictionaries are structs.

answered Jul 26, 2016 at 21:14

ghostatron

2,65024 silver badges28 bronze badges

Comments

Luke · Accepted Answer · 2016-07-26 22:14:05Z

0

You need to use a for loop instead of a for each loop and adjust the counter accordingly when adding an element

Int cntVar = 0

for x as Integer = 0 to ingredientList.count - 1 {
    if ingredientList(x + cntVar).name == "banana" {
        var orange = Ingredient(name: "orange")
        ingredientList.append(orange)
        x = x - 1
        cntVar = cntVar + 1
    }
    if ingredientList(x + cntVar).name == "orange" {
        //add needed function here
    }
}

answered Jul 26, 2016 at 22:14

Luke

8487 silver badges17 bronze badges

Collectives™ on Stack Overflow

Adding element to an array while iterating over it

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related