PHP/HTML Form Display

Question

Can someone tell me what I am doing wrong? The code runs fine, but the result that outputs is weird. It is giving me an extra column.

<?php
error_reporting(E_ALL); ini_set('display_errors', 1);
$serverName = "server\sqlexpress";
$connectionInfo = array("Database"=>"mine");
$conn = sqlsrv_connect($serverName, $connectionInfo);
if($conn === FALSE){
  die( print_r( sqlsrv_errors(), true));
}

$sql = 'SELECT id, name, age FROM names';
$records = sqlsrv_query($conn, $sql);

?>

<html>
<head>
    <meta charset="UTF-8">
    <title>Heath Data</title>
</head>
<body>
    <table width="600" border="1" cellspacing="1" cellpadding="1">
        <tr>
            <th>ID</th>
            <th>Name</th>
            <th>Age</th>
        </tr>


    <?php
    while ($employee = sqlsrv_fetch_array($records, SQLSRV_FETCH_ASSOC)){
        echo "<tr>";
        echo "<td>".$employee['id']."<td>";
        echo "<td>".$employee['name']."<td>";
        echo "<td>".$employee['age']."<td>";
        echo "<tr>";

    }
    ?>

    </table>
</body>

Here is the rersult:

Why the extra column?

close <td> tags properly

Kevin
– Kevin

2016-07-28 01:59:05 +00:00
Commented Jul 28, 2016 at 1:59 — Kevin
– Kevin, Commented Jul 28, 2016 at 1:59
Watch your closing tags </td> and </tr> !!

Ismail RBOUH
– Ismail RBOUH

2016-07-28 01:59:17 +00:00
Commented Jul 28, 2016 at 1:59 — Ismail RBOUH
– Ismail RBOUH, Commented Jul 28, 2016 at 1:59
OMG!!! I totally missed that. Thanks for your help!

Heath Atchley
– Heath Atchley

2016-07-28 02:00:29 +00:00
Commented Jul 28, 2016 at 2:00 — Heath Atchley
– Heath Atchley, Commented Jul 28, 2016 at 2:00

Jason K · Accepted Answer · 2016-07-28 01:59:27Z

3

Just need to terminate the tags

echo "<tr>";
echo "<td>".$employee['id']."</td>";
echo "<td>".$employee['name']."</td>";
echo "<td>".$employee['age']."</td>";
echo "</tr>";

answered Jul 28, 2016 at 1:59

Jason K

1,3811 gold badge12 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sajan Saj · Accepted Answer · 2016-07-28 06:20:07Z

<?php
error_reporting(E_ALL); ini_set('display_errors', 1);
$serverName = "server\sqlexpress";
$connectionInfo = array("Database"=>"mine");
$conn = sqlsrv_connect($serverName, $connectionInfo);
if($conn === FALSE)
{
die( print_r( sqlsrv_errors(), true));
}

$sql = 'SELECT id, name, age FROM names';
$records = sqlsrv_query($conn, $sql);

?>

<html>
<head>
<meta charset="UTF-8">
<title>Heath Data</title>
</head>
<body>
<table width="600" border="1" cellspacing="1" cellpadding="1">
    <tr>
        <th>ID</th>
        <th>Name</th>
        <th>Age</th>
    </tr>


<?php
while ($employee = sqlsrv_fetch_array($records, SQLSRV_FETCH_ASSOC)){
    echo "<tr>";
    echo "<td>".$employee['id']."<td>";
    echo "<td>".$employee['name']."<td>";
    echo "<td>".$employee['age']."<td>";
    echo "<tr>";

}
?>

</table>

Collectives™ on Stack Overflow

PHP/HTML Form Display

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related