finding a index of string [duplicate]

Question

I have a long array of strings with page IDs; when the current page ID matches one from the array, stuff needs to happen (alert in this test). The alert pops up on any pages, regardless if the url contains one of the ids from the array or not. What is wrong with my if statement: if(pageHref.indexOf(id))? thanks for any advise

var pageHref = window.location.href;
var ids = ['14528','14417','17529'];
for (var i = 0; i < ids.length; i++) {
    var id = ids[i];
    if (id.length > 0) {
        if(pageHref.indexOf(id)){
            //do something
            alert('a');
        }
    }
}

thanks, that was very helpful, everyone. I don't yet have reputation of 15, so it won't count my up-votes for you. Why did someone gave the answers negative? they all work — GeneticallyModified
– GeneticallyModified, Commented Jul 28, 2016 at 13:24

KCarnaille · Accepted Answer · 2016-07-28 12:47:02Z

-2

IndexOf returns a number, if the number is -1, there is no match.

Try for example. pageHref.indexOf(id) != -1.

answered Jul 28, 2016 at 12:47

KCarnaille

1,0571 gold badge10 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

finding a index of string [duplicate]

1 Answer 1

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Linked

Related