How to store value of SqlDataReader in a list<class>?

Question

Hi I have a method which returns list but i'm getting un-desired results,please let me know what is wrong in below code.

cmd2.CommandText = "select * from Blogs order by id desc"; 
SqlDataReader reader = cmd2.ExecuteReader(); 
List<Blogs> blogslist = new List<Blogs>(); 
while (reader.Read()) 
{ 
   blog.Id = Convert.ToInt16(reader["id"]); 
   blog.email = reader["email"].ToString(); 
   blog.description = reader["description"].ToString(); 
   blog.date =Convert.ToDateTime(reader["date"]); 
   blogslist.Add(blog); 
}

What is the undesired result ? Error message What is it ? Wrong results ? What is it ? Empty list ? Wrong data in a specific column. Please update your answer and be specific. — Zein Makki
– Zein Makki, Commented Jul 29, 2016 at 5:26
Blogs table has 4 different records , after reader.read() the blogslist contains the same record 4 times instead of 4 different records . — karthik kasubha
– karthik kasubha, Commented Jul 29, 2016 at 5:32

Michael Neal · Accepted Answer · 2016-07-29 05:55:31Z

3

Blog has been declared & instantiated outside of your reader.Read() statement, you are updating the same object reference each time around the loop which is why you are seeing repeating objects in your list.

cmd2.CommandText = "select * from Blogs order by id desc"; 
SqlDataReader reader = cmd2.ExecuteReader(); 
List<Blogs> blogslist = new List<Blogs>(); 
while (reader.Read()) 
{ 
   var blog = new Blogs();
   blog.Id = Convert.ToInt16(reader["id"]); 
   blog.email = reader["email"].ToString(); 
   blog.description = reader["description"].ToString(); 
   blog.date =Convert.ToDateTime(reader["date"]); 
   blogslist.Add(blog); 
}

Please mark this as your accepted answer if it solves your problem.

edited Jul 29, 2016 at 5:55

answered Jul 29, 2016 at 5:33

Michael Neal

1651 silver badge9 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Zein Makki Over a year ago

He posted the code as plain text at first, that's what the <classType> part got removed somehow.

Michael Neal Over a year ago

Thanks user3185569, that eliminates that part then.

karthik kasubha Over a year ago

Thanks a lot Michael :-)

Collectives™ on Stack Overflow

How to store value of SqlDataReader in a list<class>?

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related