sending data from form to database not working (php, sql)

Question

I'm making a simple registration form for a test website and for some reason it isn't sending the data to the database, and I don't get an visual error. I've searched around for a fix but haven't found any that work.

This is basically my form (I only copied the form part of the page):

    <form action="includes/insert.php" method="post">
        <h3>Username</h3>
        <input type="text" name="username">
        <br>
        <br>
        <h3>Email Address</h3>
        <input type="email" name="email">
        <br>
        <br>
        <h3>Password</h3>
        <input type="password" name="password">
        <br>
        <br>
        <br>
        <input id="submit-btn" type="submit" name="submit" value="Submit">
    </form>

As you can see everything is as its suppose to be.

and this is my insert.php

<?
define('DB_NAME', 'logindb');
define('DB_USER', 'root');
define('DB_PASSWORD', 'password');
define('DB_HOST', 'localhost');

$link = mysql_connect(DB_HOST, DB_USER, DB_PASSWORD);

if (!$link) {
    die('Could not connect: ' . mysql_error());
}

$db_selected = mysql_select_db(DB_NAME, $link);

if (!$db_selected) {
    die('Can\'t use ' . DB_NAME . ': ' . mysql_error());
}

$username = $_POST['username'];
$email = $_POST['email'];
$password = $_POST['password'];

$sql = "INSERT INTO `users` (`id`, `username`, `email`, `password`, `timestamp`) VALUES (NULL, '$username', '$email', '$password', CURRENT_TIMESTAMP)";

if (!mysql_query($sql)) {
    die('Error: ' . mysql_error());
}

mysql_close();
?>

The id column is most likely an auto increment column, therefore you should remove it from the INSERT INTO statement. — ViRuSTriNiTy
– ViRuSTriNiTy, Commented Aug 2, 2016 at 19:47
Please stop using mysql_* functions. These extensions have been removed in PHP 7. Learn about prepared statements for PDO and MySQLi and consider using PDO, it's really pretty easy. — Jay Blanchard
– Jay Blanchard, Commented Aug 2, 2016 at 19:53
Little Bobby says your script is at risk for SQL Injection Attacks.. Even escaping the string is not safe! Don't believe it? — Jay Blanchard
– Jay Blanchard, Commented Aug 2, 2016 at 19:53
Never store plain text passwords! Please use PHP's built-in functions to handle password security. If you're using a PHP version less than 5.5 you can use the password_hash() compatibility pack. Make sure you don't escape passwords or use any other cleansing mechanism on them before hashing. Doing so changes the password and causes unnecessary additional coding. — Jay Blanchard
– Jay Blanchard, Commented Aug 2, 2016 at 19:53
@ViRuSTriNiTy Inserting a NULL value for an autoincrement field as done here works just fine so long as that field is specified as NOT NULL — Mike Brant
– Mike Brant, Commented Aug 2, 2016 at 19:56

Duane Lortie · Accepted Answer · 2016-08-02 19:51:07Z

1

Opening PHP tag is

<?php

Recent versions of PHP do not enable the short code syntax by default.

answered Aug 2, 2016 at 19:51

Duane Lortie

1,2601 gold badge12 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ebniax.Axel Over a year ago

Thanks, i forgot about that :)

muya.dev · Accepted Answer · 2016-08-02 19:51:16Z

0

Use NOW() instead of CURRENT_TIMESTAMP.

answered Aug 2, 2016 at 19:51

muya.dev

9751 gold badge13 silver badges35 bronze badges

2 Comments

Jay Blanchard Over a year ago

CURRENT_TIMESTAMP is a synonym for NOW() and dev.mysql.com/doc/refman/5.5/en/…

Ebniax.Axel Over a year ago

Is NOW() more preferable than CURRENT_TIMESTAMP?

Collectives™ on Stack Overflow

sending data from form to database not working (php, sql)

2 Answers 2

1 Comment

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related