Cannot insert form data into a MySQL database using PHP

Question

I am trying to insert data submitted in a form, into a MySQL Database, and I can't see the problem in my code(except for MySQL injection, that I will work to resolve after actually being able to insert any data). I have searched in Stack Overflow, and found someone who probably worked by the same manual, but I work in localhost, he's on GoDaddy. The solution given there doesn't work for me.

Here is my code for the HTML and the PHP code:

<?php 
  require'connection/connect.php';
  ?>
  <?php
  if(isset($_POST['Register'])){
      session_start();
      $Fname = $_POST['FirstName'];
      $Lname = $_POST['LastName'];
      $Email = $_POST['Email'];
      $pw = $_POST['Password'];


  $sql= $con->query("INSERT INTO user (Fname,Lname,Email,Password) values('{$Fname}', '{$Lname}', '{$Email}', '{$pw}')");
  }

  ?>
  <!DOCTYPE html >
  <html>
  <head>
  <link href="css/Master.css" rel="stylesheet" type="text/css" />
  <link href="css/Menu.css" rel="stylesheet" type="text/css" />
  <title>Register</title>
  </head>

  <body>


  <div class="container">
    <div class="header">

    </div>
    <div class="menu">
      <div id="NavBar">
       <nav>
       <ul>
       <li>
       <a href="Login.php">Login</a>
       </li>
       <li>
       <a href="Register.php">Register</a>
       </li>
       </ul>
       </nav>
  </div>

    </div>
    <div class="leftBody"></div>
    <div class="rightBody">
      <form  action="" method="post" name="RegisterForm" id="RegisterForm">
      <div class="FormElement">
      <input name="FirstName" id="FirstName" type="text" placeholder="First Name" class="TField">
      </div><br>
       <div class="FormElement">
      <input name="LastName" id="LastName" type="text" placeholder="Last Name" class="TField">
      </div><br>
       <div class="FormElement">
      <input name="Email" id="Email" type="email" placeholder="E-Mail" class="TField">
      </div><br>
       <div class="FormElement">
      <input name="Password" id="Password" type="password" placeholder="Password" class="TField">
      </div><br>
      <input name="Register" id="Register" type="button" value="Register" class="regButton">
      </form>

    </div>
    <div class="footer"></div>


  </div>

  </body>
  </html>

And this is my connection.php file: That it does show that it connects.

<?php
$host="localhost";
$username="root";
$password="";
$dataBase="users";
$con=mysqli_connect($host,$username,$password,$dataBase);
if (!$con) {
    die("Could not connect: " . mysqli_error());
}
echo "Connected successfully";
?>

And a picture of my database in phpMyAdmin: Database

I have tried also using this line like this for some reason, but to no avail.:

$sql= $con->query("INSERT INTO user
                          (Fname,Lname,Email,Password)   
                   values ('Fname', 'Lname', 'Email', 'pw')");

('Fname', 'Lname', 'Email', 'pw') you're trying to literally enter those values as strings rather than the POST arrays/variables. Guess what you're missing here? Clue: Think "money" ;-) — Funk Forty Niner
– Funk Forty Niner, Commented Aug 4, 2016 at 11:41
"and found someone who probably worked by the same manual, but I work in localhost, he's on GoDaddy" - This smells like you're accessing as file:///file.xxx rather than http://localhost/file.xxx. — Funk Forty Niner
– Funk Forty Niner, Commented Aug 4, 2016 at 11:46
@GrowingDev Ok, I see your submit button and should be an submit type, not button and Sanjiv Dhakal's answer picked up on that and I overlooked it. That should work. — Funk Forty Niner
– Funk Forty Niner, Commented Aug 4, 2016 at 11:51

Sanjiv Dhakal · Accepted Answer · 2016-08-04 11:50:15Z

5

i didn't see submit button that actually submit the form. So if i am not wrong please try to use

<input name="Register" id="Register" type="submit" value="Register" class="regButton">

answered Aug 4, 2016 at 11:50

Sanjiv Dhakal

3163 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Funk Forty Niner Over a year ago

This looks promising. I'll upvote if it works for them. I overlooked that in the question; good catch.

Funk Forty Niner Over a year ago

"WOW! i cant believe it. it was because of the type="button" error! it works fine now. thank you very much to all of you, and especially for you @UttamPanara for pointed out to me. – GrowingDev" - Yep, that was it alright. ;-)

GabMic Over a year ago

Yes, that's it. and i have also updated the OP with this answer. Thanks.

RiggsFolly · Accepted Answer · 2016-08-04 11:44:20Z

-1

your code should be run

$sql= $con->query("INSERT INTO user 
                           (Fname,Lname,Email,Password)   
                     VALUES('$Fname', '$Lname', '$Email', '$pw')");

edited Aug 4, 2016 at 11:44

RiggsFolly

94.7k22 gold badges108 silver badges152 bronze badges

answered Aug 4, 2016 at 11:43

arash rahimi

651 silver badge12 bronze badges

2 Comments

Funk Forty Niner Over a year ago

They said they already tried that. What do you think my "comment" was about. They had values('{$Fname}', '{$Lname}', '{$Email}', '{$pw}') also; same thing here.

Jay Blanchard Over a year ago

Little Bobby says your script is at risk for SQL Injection Attacks. Learn about prepared statements for MySQLi. Even escaping the string is not safe! Don't believe it?

Collectives™ on Stack Overflow

Cannot insert form data into a MySQL database using PHP

2 Answers 2

3 Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related