Angular Js : onchange in directive at class attribute is not working

Question

controldirective.js

  function validVehicleyear($scope, $http) {
        return {
            restrict: 'C',
            scope: {
                ngModel: '=',                
            },
            link: function (scope, element, attrs, ngModel) {
                element.bind('change', function () {
                    console.log('here in validVehicleyear');
                    $http.get('api.php/'+scope.ngModel)
                            .then(function (response) {
                                $scope.answers.VehicleMake = response.data;
                            });
                });
            }
        }
    }

plnkr.co/edit/BFGXr7LNAe0KvQipj9JJ?p=preview

I wrote a directive validVehicleyear on class at Vehicle year question, this i want to call on change of year and set new options for Vehicle make, but it not working.

Class="form-control **valid-vehicleyear** ng-not-empty ng-dirty ng-valid-parse ng-valid ng-valid-required ng-touched"

gyc · Accepted Answer · 2016-08-05 11:30:34Z

1

You forgot to declare your directive function

.directive('validVehicleyear', validVehicleyear)

http://plnkr.co/edit/9bGXO96s0BJVik7VecFU?p=preview

answered Aug 5, 2016 at 11:30

gyc

4,3586 gold badges37 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

pandu das Over a year ago

thanks . I updated plunker. you did changes in changed <select valid-vehicleyear in controlDirective.js, I can not line like that, So I created a class on which i want to create a directive.

pandu das Over a year ago

restrict: 'C', works to cretae directive but its not working

gyc Over a year ago

@pandudas yes, I mistook C for comment directive. But regardless the plunker works. An alert popsup when you change the year. EDIT: oh I see what you mean

pandu das Over a year ago

Yes I missed to add above line in plunker. At the final I want to make it working with restrict: 'C', why it is directive not working on class. What I am missing.

gyc Over a year ago

Right, I couldn't figure why it doesn't work with class. Maybe a conflicting class name css vs directive? I never use directive as css classes. I find it confusing and very bad practice. You should probably refactor your code.

|

Collectives™ on Stack Overflow

Angular Js : onchange in directive at class attribute is not working

1 Answer 1

7 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related