Insert multiple rows using for loop

Question

I want to insert multiple rows into a table using for loop, but having some errors. What is wrong in this code?

$sql=mysql_query("INSERT INTO pl_tbl (p_id,po_name,po_val) VALUES

            for ($i=0;$i<$count;$i++) 
            {
                ('$id','$data['data']['name_'.$i]','$data['data']['val_'.$i]')");
            }

rokas · Accepted Answer · 2016-08-09 06:53:12Z

4

Try it:

$sql = "INSERT INTO pl_tbl (p_id,po_name,po_val) VALUES";
$values = [];

for ($i=0;$i<$count;$i++)
{
    $values[] = "('$id','$data['data']['name_$i]','$data['data']['val_$i]')";
}

$sql .= join(',', $values);
$result = mysql_query($sql);

edited Aug 9, 2016 at 6:53

answered Aug 9, 2016 at 6:43

rokas

1,5899 silver badges16 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

rokas Over a year ago

then try $values = array();

RPaul Over a year ago

Doesn't this accomplish him saving all his data in one row instead of multiple rows?

RPaul Over a year ago

@rokas thanks, i now see it. Didn't not know you could send multiple rows like that

halfer · Accepted Answer · 2017-10-20 19:04:11Z

3

Codeigniter active record has a function insert_batch i think that is what you need:

$data = array(
array(
  'p_id' => 'My id' ,
  'po_name' => 'My Name' ,
  'po_val' => 'My val'
),
array(
  'title' => 'Another title' ,
  'name' => 'Another Name' ,
  'date' => 'Another date'
)
);

$this->db->insert_batch('pl_tbl', $data);

Other way:

for ($i=0;$i<$count;$i++) 
  {
     $data = array(
      array(
      'p_id' => $id ,
      'po_name' => $data['data']['name_'.$i] ,
      'po_val' => $data['data']['val_'.$i]
     );
     $this->db->insert('pl_tbl', $data); 
  }

edited Oct 20, 2017 at 19:04

halfer

20.2k20 gold badges110 silver badges207 bronze badges

answered Aug 9, 2016 at 6:43

kuldeep

3181 silver badge10 bronze badges

2 Comments

robins Over a year ago

i got like this INSERT INTO pl_tbl () VALUES (), (), ()

kuldeep Over a year ago

please use insert_batch function form CI

Pruthviraj Chudasama · Accepted Answer · 2016-08-09 07:41:01Z

2

try this simple code its should work for you..

<?php
  for($i=0;$i<$count;$i++)
  {
     $sql="INSERT INTO pl_tbl (p_id,po_name,po_val) VALUES ('$id','$data['data']['name_'.$i]','$data['data']['val_'.$i]')";
     $result = mysql_query($sql);
  }
?>

thanks

answered Aug 9, 2016 at 7:41

Pruthviraj Chudasama

4462 silver badges15 bronze badges

Comments

Jay Kareliya · Accepted Answer · 2016-08-09 10:42:28Z

1

$data=array();
for ($i=0;$i<$count;$i++) 
{
   $temp=array();
   $temp['p_id'] = 'My id'; //actual value
   $temp['po_name'] = 'My Name'; //actual value
   $temp['po_val'] = 'My val'; //actual value
   array_push($data,$temp);
}
$this->db->insert_batch('pl_tbl', $data);

You can try with this code.

edited Aug 9, 2016 at 10:42

Jay Kareliya

7707 silver badges21 bronze badges

answered Aug 9, 2016 at 6:57

Mandip Vora

3091 gold badge2 silver badges14 bronze badges

1 Comment

Mandip Vora Over a year ago

i updated my code. please try again. i hope it will be working.

Dhaval Purohit · Accepted Answer · 2016-08-09 06:49:00Z

0

try to save the whole query in a variable and then run with the mysql_query should help you.

so code will be

$sql_query="INSERT INTO pl_tbl (p_id,po_name,po_val) VALUES ";

    for ($i=0;$i<$count;$i++) 
    {
        $sql_query.="('$id','".$data["data"]["name_".$i]."','".$data["data"]["val_".$i]."') ";
    }
$sql=mysql_query($sql_query);

answered Aug 9, 2016 at 6:49

Dhaval Purohit

1,29011 silver badges29 bronze badges

Comments

RPaul · Accepted Answer · 2016-08-09 06:54:58Z

0

If I understood this correctly, you should be doing this

for ($i=0;$i<$count;$i++) {
    $sql=mysql_query("INSERT INTO pl_tbl (p_id,po_name,po_val) VALUES  ('$id','".$data['data']['name_'.$i]."','".$data['data']['val_'.$i]."')");
}

answered Aug 9, 2016 at 6:54

RPaul

667 bronze badges

Collectives™ on Stack Overflow

Insert multiple rows using for loop

6 Answers 6

3 Comments

2 Comments

Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

3 Comments

2 Comments

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related