Insert in sqlite python doesn't change table

Question

I'm create simple class for SQLite datadase and when I'm insert new row table doesn't change.

DB.py

import sqlite3

class DB:
    def __init__(self, **kwargs):
        self.db = sqlite3.connect('passwods.db')
        self.c = self.db.cursor()
        self.c.execute('CREATE TABLE IF NOT EXISTS passwords (name, value)')

    def insert(self, alias, cipher):
        column = (alias, cipher)
        self.c.execute('INSERT INTO passwords (name, value) VALUES (?,?)',  column)
        self.db.commit()

    def get(self, alias):
        pk = (alias,)
        self.c.execute('SELECT * FROM passwords WHERE name=?', pk) 

    def getAll(self):
        self.c.execute('SELECT * FROM passwords')

Interactive shell

>>> from DB import DB
>>> db = DB()
>>> db.insert('firstName', 'firstValue')
>>> print(db.getAll())
None
>>>

exactly as polku says. for database "transactions" other than queries, you have to use the commit() after the execute(). In your case, it would probably be self.db.commit() at the end of the insert function — Ma0
– Ma0, Commented Aug 12, 2016 at 11:55
>>> from DB import DB >>> db = DB() >>> db.insert('firstName', 'firstValue') >>> print(DB().getAll()) None >>> — Rodion
– Rodion, Commented Aug 12, 2016 at 12:10

pschill · Accepted Answer · 2016-08-12 12:23:30Z

1

Your method getAll has no return statement. If you add it, you can see that the table actually changes:

def getAll(self):
    self.c.execute("SELECT * FROM passwords")
    return self.c.fetchall()

answered Aug 12, 2016 at 12:23

pschill

5,6592 gold badges24 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Rodion Over a year ago

Thank! Maybe I need some break

Collectives™ on Stack Overflow

Insert in sqlite python doesn't change table

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related