ASP.NET MVC Attribute-Routing with Null Values

Question

Here is a paste of the action method MovieCustomer in the EverythingController. The Viewmodel is used to Combine two Models: Customer & Movies, and is populated with information from the Database via the ApplicationDbContext (_context).

The Routeing works successfully and renders the page when there are values for MovieId and CustomerId

e.g. /Everything/MovieCustomer/1/1

I want the page to also load if one or both of the values are null. So far both of the int parameters were made nullable and there is an if statement in the method to change the parameters to 1 if either is null. So far if the values are null the browser returns a 404 error.

How can I get the page to function when one or either of the parameters are null? Thanks

[Route("Everything/MovieCustomer/{movieId}/{customerId}")]
public ActionResult MovieCustomer(int? movieId, int? customerId)
{
    var viewmodel = new ComboViewModel
    {
        _Customers = new List<Customer>(),
        _Movies = new List<Movies>(),
        _customer = new Customer(),
        _movie =  new Movies()
    };
    viewmodel._Customers = _context.Customers.ToList();
    viewmodel._Movies = _context.Movies.ToList();

    if (!movieId.HasValue)
        movieId = 1;

    if (!customerId.HasValue)
        customerId = 1;

    viewmodel._customer = viewmodel._Customers.SingleOrDefault(a => a.Id == customerId);
    viewmodel._movie = viewmodel._Movies.SingleOrDefault(a => a.Id == movieId);

    return View(viewmodel);
}

stackoverflow.com/questions/50248828/… (see the comments to the answer). — AnorZaken
– AnorZaken, Commented Jul 1, 2021 at 21:07

krivtom · Accepted Answer · 2016-08-14 15:37:27Z

33

You can achieve this using separate routes, or change your parameters to be optional.

When using 3 attributes, you add separate routes for each of the options that you have - when no parameters are specified, when only movieId is specified, and when all 3 parameters are specified.

[Route("Everything/MovieCustomer/")]
[Route("Everything/MovieCustomer/{movieId}")]
[Route("Everything/MovieCustomer/{movieId}/{customerId}")]
public ActionResult MovieCustomer(int? movieId, int? customerId)
{
    // the rest of the code
}

Alternatively you an combine change your route parameters to optional (by adding ? in route definition) and this should cover all 3 cases that you have:

[Route("Everything/MovieCustomer/{movieId?}/{customerId?}")]
public ActionResult MovieCustomer(int? movieId, int? customerId)
{
    // the rest of the code
}

Keep in mind that neither sample supports the case where you provide only customerId.

answered Aug 14, 2016 at 15:37

krivtom

25k10 gold badges53 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

toha Over a year ago

this is correct one... Mine : [Route("/KodePos/Print/{sKeyword?}")] public IActionResult Print(string? sKeyword) {}

Amoenus · Accepted Answer · 2020-03-25 08:17:10Z

1

Interstingly, I had to add optional parameter to the signature as well for it to work from Angular client like so:

[HttpGet]
[Route("IsFooBar/{movieId?}/{customerId?}")]
[Route("IsFooBar/null/{customerId?}")]
public bool IsFooBar(int? movieId = null, int? customerId = null)
{
    // the rest of the code
}

In Angular

  public IsFoobar(movieId: number | null, customerId: number | null): Observable<boolean> {
    return this.httpService.get<boolean>(`api/IsFooBar/${movieId}/${customerId}`);
  }

answered Mar 25, 2020 at 8:17

Amoenus

1487 bronze badges

Comments

David Osborne · Accepted Answer · 2019-03-12 19:55:31Z

0

Keep in mind that neither sample supports the case where you provide only customerId.

Check it out. I think you can use the multiple route method with EVEN ANOTHER route like this if you do want to provide only customerId:

[Route("Everything/MovieCustomer/null/{customerId}")]

answered Mar 12, 2019 at 19:55

David Osborne

874 bronze badges

Collectives™ on Stack Overflow

ASP.NET MVC Attribute-Routing with Null Values

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related