How to properly use By class in selenium with python

Question

I've written a code to test a page in python with selenium. The code works but now I'm trying to rewrite it better.
I have created a locators.py file as described in the following documentation: selenium python binding - page objects.
For simple locators this is straightforward. This is what I've done so far:

from selenium.webdriver.common.by import By

class PhotoHomePageLocators(object):
"""A class for photographer home page locators. All photographer interface home page locators should come here"""
add_new_project_btn = (By.CLASS_NAME, 'addProject')
view_all_projects_btn = (By.CLASS_NAME, 'viewAllProjects')


class NameCoverPageLocators(object):
"""A class for name and cover home page locators. All name and cover page locators should come here"""
project_name_txt_box = (By.XPATH, '//*[@id="rform_pt2_0"]')
client_name_txt_box = (By.XPATH, '//*[@id="rform_pt2_1"]')
client_email_txt_box = (By.XPATH, '//*[@id="rform_pt2_2"]')

but I have the following line in my code which I'm uncertain how to write so it fits the above syntax:

driver.find_element_by_class_name('coverUpload').find_element_by_class_name('pButton').click()

I'm locating a class within a class, there are several pButton classes in the page, but only one inside the coverUpload class.

try to avoid locators starting with //* whenever possible, they are very inefficient. Providing the name of tag is better. Or even better, when using @id, is using By.ID — timbre timbre
– timbre timbre, Commented Aug 14, 2016 at 15:34
Thank you, @KirilS. I'll have to replace those as well. I'm not sure I fully understand the structure of the xpath locator. but that's for a different question I guess. — ShaiS
– ShaiS, Commented Aug 14, 2016 at 16:17

Ath0s · Accepted Answer · 2021-04-13 15:46:51Z

1

You should be able to arrange the line you are asking about as follows:

someName = driver.find_element_by_class_name('coverUpload')
ButtonName = someName.find_element_by_class_name('pButton')
ButtonName.click()

answered Apr 13, 2021 at 15:46

Ath0s

111 bronze badge

Sign up to request clarification or add additional context in comments.

Comments

George Imerlishvili · Accepted Answer · 2021-04-13 17:06:02Z

1

instead of 2 class search maybe you can use relative Xpath if That element is unique.

elem = driver.find_element(By.XPATH, '//*[@class="coverUpload"]//*[@class="pButton"]')
elem.click()

answered Apr 13, 2021 at 17:06

George Imerlishvili

1,9852 gold badges16 silver badges24 bronze badges

Comments

AirtonCarneiro · Accepted Answer · 2020-03-01 19:05:00Z

0

Use find_elements_by_class_name

answered Mar 1, 2020 at 19:05

AirtonCarneiro

1321 silver badge8 bronze badges

Comments

Yaakov Bressler · Accepted Answer · 2021-04-13 17:11:10Z

0

I'd suggest using selenium's find_element_by_css_selector which allows for more robust and complex chaining of classes:

css_selector = '.coverUpload . pButton'
button = find_element_by_css_selector(css_selector)
button.click()

Note: css selectors can be brittle, so make sure you have either a resilient selection strategy.

answered Apr 13, 2021 at 17:11

Yaakov Bressler

12.7k5 gold badges66 silver badges96 bronze badges

Comments

bekfen · Accepted Answer · 2022-08-14 19:43:44Z

0

The classes found in locators.py that were provided don't contain class attributes for locators of "coverUpload" nor "pButton" however, using one of the locators defined in the example, it would look like the below:

driver.find_element(*PhotoHomePageLocators.add_new_project_btn).click()

Assuming the intention was to click on the button that appears to "add a new project".

answered Aug 14, 2022 at 19:43

bekfen

815 bronze badges

Comments

Aleksandr Nokhrin · Accepted Answer · 2022-10-29 08:00:35Z

0

To find the button exactly with provided attributes, I'd use "button" instead of "*". I believe this is gonna be more efficient.

elem = driver.find_element(By.XPATH, '//button[@class="coverUpload"]//button[@class="pButton"]')

answered Oct 29, 2022 at 8:00

Aleksandr Nokhrin

112 bronze badges

Collectives™ on Stack Overflow

How to properly use By class in selenium with python

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related