jQuery/Javascript: What's wrong with my 'If'?

Question

I have a little hunk of my code here:

if(".level-0.find('.children').length == 1"){
     $(".level-0 > a").attr("href", ""); 
 };

Basically I'm saying "If Level 0 has a class of '.children', don't rewrite the HREF in it's link!"

The problem is that it ALWAYS overwrites the HREF, as if there were no conditional. I've changed that "== 1" to "== 10000000" or "20" or "15" and it ALWAYS overwrites the HREF. It's just acting as if there's no conditional statement. I'm sure this is a synatx goof, but I can't see it.

Again, thanks for helping a n00b stumble his way towards minimal competency. Here's the code we're looking to change, just for context.

<li class="level-0 page_item page-item-264"><a href="http://www.domain.com.php5-15.dfw1-1.websitetestlink.com/wordpress/?page_id=264" title="Ca$h Rulez">Ca$h Rulez</a>
<ul class='children'>
    <li class="level-1 page_item page-item-266"><a href="http://www.domain.com.php5-15.dfw1-1.websitetestlink.com/wordpress/?page_id=266" title="1994">1994</a></li>
    <li class="level-1 page_item page-item-268"><a href="http://www.domain.com.php5-15.dfw1-1.websitetestlink.com/wordpress/?page_id=268" title="1995">1995</a></li>
    <li class="level-1 page_item page-item-270"><a href="http://www.domain.com.php5-15.dfw1-1.websitetestlink.com/wordpress/?page_id=270" title="1996">1996</a></li>
    <li class="level-1 page_item page-item-272"><a href="http://www.domain.com.php5-15.dfw1-1.websitetestlink.com/wordpress/?page_id=272" title="1997">1997</a></li>
    <li class="level-1 page_item page-item-274"><a href="http://www.domain.com.php5-15.dfw1-1.websitetestlink.com/wordpress/?page_id=274" title="1998">1998</a></li>
    <li class="level-1 page_item page-item-276"><a href="http://www.domain.com.php5-15.dfw1-1.websitetestlink.com/wordpress/?page_id=276" title="1999">1999</a></li>
    <li class="level-1 page_item page-item-278"><a href="http://www.domain.com.php5-15.dfw1-1.websitetestlink.com/wordpress/?page_id=278" title="2000">2000</a></li>
    <li class="level-1 page_item page-item-280"><a href="http://www.domain.com.php5-15.dfw1-1.websitetestlink.com/wordpress/?page_id=280" title="2001">2001</a></li>
</ul>
</li>

@Peter - I am afraid not. This is straight from the specification: The result is false if the argument is the empty String (its length is zero); otherwise the result is true. — ChaosPandion
– ChaosPandion, Commented Oct 9, 2010 at 19:34
@Chaos - My bad. It's not a syntax error... I meant "typing error", OP provided a string in the if statement, so like you say, the result is always true..... This is because OP meant to create jQuery object instead: $(".level-0").find('.children').length == 1 vs ".level-0.find('.children').length == 1" — Peter Ajtai
– Peter Ajtai, Commented Oct 9, 2010 at 19:41

BalusC · Accepted Answer · 2010-10-09 04:55:22Z

9

Shouldn't it rather be

if ($(".level-0").find('.children').length == 1) {
    $(".level-0 > a").attr("href", ""); 
}

?

Late friday maybe? :)

answered Oct 9, 2010 at 4:55

BalusC

1.1m377 gold badges3.7k silver badges3.6k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dr.Molle · Accepted Answer · 2010-10-09 05:22:49Z

0

You cant use your condition there like you do, because if you have more than 1 .level-0 , you got no relation between .level-0 and its >a
If your condition matches only 1 time, all .level-0>a inside the document will be accessed.

$('>a',$(".level-0").has('.children'))

...will select all child-<a>'s of .level-0 , if .level-0 contains at least 1 .children

edited Oct 9, 2010 at 5:22

answered Oct 9, 2010 at 5:17

Dr.Molle

117k16 gold badges200 silver badges206 bronze badges

Collectives™ on Stack Overflow

jQuery/Javascript: What's wrong with my 'If'?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related