How do i replace "-" in javascript?

Question

Let say the variable name is

var name = "Stack overflow is great";

I want to change it to

var name = "Stack-overflow-is-great";

I did this

name.replace(/ /g, '-');

and here is the result

var name = "Stack-overflow-is-great-";

There is an extra dash at the end, how do i prevent from the last dash to appear in my string?

make sure you dont have any spaces at the end. Just as a work around you can do name.replace(/-$/g,''); — Nagaraju
– Nagaraju, Commented Aug 17, 2016 at 5:09
for me it works properly, you might be missing whitespaces which are there just trim it like name.trim().replace(/ /g, '-');. — Mritunjay
– Mritunjay, Commented Aug 17, 2016 at 5:10
Just to note, you can test regex using regex101.com - Input your string and then you can see exactly how regex will react to your string. — Dandy
– Dandy, Commented Aug 17, 2016 at 5:44

nnnnnn · Accepted Answer · 2016-08-17 05:15:24Z

1

I believe, your actual input contains trailing spaces, because your example works ok.

Remove trailing space with trim function as I've showed in snippet below.

var name = "Stack overflow is great ";
var newName = name.trim().replace(/ /g, '-');
console.log(newName);

edited Aug 17, 2016 at 5:15

nnnnnn

150k30 gold badges210 silver badges247 bronze badges

answered Aug 17, 2016 at 5:13

userlond

3,8442 gold badges41 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

nnnnnn Over a year ago

Stack Overflow's snippet window has a handy console mirror, so please use console.log() rather than alert() for this sort of thing.

Nihar Sarkar · Accepted Answer · 2016-08-17 05:22:48Z

0

Using concat() function you can add expression at the end of the string .

(function(){
var name = "Stack overflow is great";
name=name.replace(/ /g, '-');
var name=name.concat(expression);

}());

answered Aug 17, 2016 at 5:22

Nihar Sarkar

1,2991 gold badge15 silver badges26 bronze badges

Comments

mmushtaq · Accepted Answer · 2016-08-17 05:24:22Z

0

You can use endWith to check if your name has space at the End.

var name = "Stack overflow is great ";
if(name.endsWith(" ")){
 name = name.substring(0, name.length -1);
 }
console.log(name.replace(/ /g, '-'));

answered Aug 17, 2016 at 5:24

mmushtaq

3,5307 gold badges34 silver badges50 bronze badges

Comments

Sergio Marron · Accepted Answer · 2016-08-17 05:28:04Z

0

You have to assign the return value from the replace() function to a variable. The replace() function does not change the String object it is called on. It simply returns a new string.

    var name  = "Stack overflow is great";

    name = name.replace(/ /g, '-');

    console.log(name);

edited Aug 17, 2016 at 5:28

answered Aug 17, 2016 at 5:21

Sergio Marron

5213 silver badges9 bronze badges

1 Comment

Nagaraju Over a year ago

this is just similar to the question asked

Abdullah · Accepted Answer · 2016-08-17 05:29:26Z

0

One quick solution is to exclude the last dash.

            var name = "Stack overflow is awsome "
            name = name.replace(/ /g,'-');
            console.log(name);
            var pos = name.lastIndexOf('-');
            console.log(pos);
            name = name.substring(0,pos);

            console.log(name);

edited Aug 17, 2016 at 5:29

answered Aug 17, 2016 at 5:16

Abdullah

9659 silver badges18 bronze badges

1 Comment

nnnnnn Over a year ago

Did you test this on cases where there isn't a dash at the end of the string?

Collectives™ on Stack Overflow

How do i replace "-" in javascript?

5 Answers 5

1 Comment

Comments

Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related