Using a URL as a URL parameter in Django

Question

In my models, I have the following:

class Content(models.Model):
    address = models.URLField(unique=True)

In my urls, I have this pattern:

url(r'^content_detail/(?P<address>[a-zA-Z-_./:0-9-_+=?;~@#%^&*(){}|`<>]+)/$', views.content_detail),

Yes, seriously, thats the pattern Im using. Basically, i took a look at all the characters that can be used in a URL, and made the pattern. Now, my question is, will it work? Its been working fine in my testing but I am no regex expert. Any way to improve this? If possible, can anyone give me a django url specific regex for URLs? Thanks a lot.

I would recommend to pass the url in a GET parameter rather than putting it in the url path. — knbk
– knbk, Commented Aug 20, 2016 at 18:57

Aswin Kumar K P · Accepted Answer · 2016-08-20 12:25:06Z

1

I think you have added all the possible symbols, alphabets and numbers in your URL.

url(r'^content_detail/(?P<address>.*)/$', views.content_detail),

This allows all characters in your URL.

answered Aug 20, 2016 at 12:25

Aswin Kumar K P

1,1122 gold badges12 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Aamir Rind Over a year ago

Shouldn't it be .+ as at-least something is required.

Aswin Kumar K P Over a year ago

Yes.. Sorry I did not notice the + in question.

rafalmp · Accepted Answer · 2016-08-20 12:56:15Z

1

Your regex will fail on IDNs (Internationalized Domain Names) containing Unicode characters. I think the easiest way would be matching on .+ as Aswin Kumar K P wrote in his answer, then validating the captured pattern using Django's URLValidator. You can find Django's regular expressions for URLs in that validator's source code: URLValidator

answered Aug 20, 2016 at 12:56

rafalmp

4,0883 gold badges32 silver badges36 bronze badges

Collectives™ on Stack Overflow

Using a URL as a URL parameter in Django

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related