import all in typescript does not work

Question

I don't know if I am stupid, but, I have installed web-request module:

npm install web-request

it is installed, it is present in node modules. I try to use it:

import * as WebRequest from 'web-request';
export class MyHttp {

public static getUrl() {

console.log('hello');
  WebRequest.get('http://www.google.com/').then(()=> {
     console.log('success'); 
});

}
 }

Then I use it in the test:

import {MyHttp} from '../../../services/MyHttp';

describe('Request', () => {

  fit('should be successful', () => {
   MyHttp.getUrl();
   setTimeout(()=> {
   expect(true).toBe(true);
},5000);

 });

 });

The console output is:

hello

I cannot see 'success' output at all.

The typings is ok, I am able to enter web-request\index.d.ts, that looks fine.

What am I doing wrong ? :(

Your test runner is exiting immediately because it's not aware that you are running async behavior. Read the jasmine docs for how to write an async test function. — Ryan Cavanaugh
– Ryan Cavanaugh, Commented Aug 22, 2016 at 18:17
Don't create classes consisting of only static methods, and don't export them: stackoverflow.com/q/29893591/1048572 — Bergi
– Bergi, Commented Aug 22, 2016 at 18:22
Have you tried adding a catch error handler to the promise? — Bergi
– Bergi, Commented Aug 22, 2016 at 18:23
Even when I use Promise then in the test it wont success either. I use static, so the tests are clear, I've read a rule, no new keyword in tests. — Jerzy Gruszka
– Jerzy Gruszka, Commented Aug 22, 2016 at 18:32

qballer · Accepted Answer · 2016-08-23 15:09:29Z

1

I'm assuming the tests needs a callback to be called in order for the test runner to know that it finished and that it is Async. Here is an example base on your code. You can read about jasmine for instance here.

import * as WebRequest from 'web-request';
export class MyHttp {
    public static async getUrl() {
        console.log('hello');
        await WebRequest.get('http://www.google.com/')
        console.log('success'); 
    }   
}
it('should be successful', () => {
    MyHttp.getUrl();
    expect(true).toBe(true);
});

edit: If you look in the docs of web-request it seems that they use await. There is no need for then after the function call. This pauses execution until the promise is resolved and gives you the value in the return object. While not suitable for all things it can make sense for testing.

edited Aug 23, 2016 at 15:09

answered Aug 22, 2016 at 19:22

qballer

2,1112 gold badges22 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Jerzy Gruszka Over a year ago

Yep, I tried that callback , it does not work either

qballer Over a year ago

I've changes my answer a bit.

Tamas Hegedus Over a year ago

function should be async

Collectives™ on Stack Overflow

import all in typescript does not work

1 Answer 1

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related