Common refactoring pattern for Rails model

Question

Is there a pattern to refactor such a construct into a readable single line?

def show_section
  @news = News.all_active
  @news = @news.where(:section => params[:section]) unless params[:section] == "all"
  @news = @news.all
end

I use Rails 3 and Ruby 1.9.2

Matt · Accepted Answer · 2010-10-12 12:39:31Z

3

@news = News.all_active.where(params[:section] == "all" ? nil : {:section => params[:section]})

You can get rid of @news.all - in Rails 3 query will be executed when you use the resulting ActiveRecord::Relation object (for example when you call each or first on it). Passing nil to where method will do nothing.

If all_active is a method, you can refactor it into a scope and then call it in a chain.

Great resources on Rails 3 queries:

edited Oct 12, 2010 at 12:39

answered Oct 12, 2010 at 12:23

Matt

5,3983 gold badges33 silver badges43 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jacob · Accepted Answer · 2010-10-12 17:10:50Z

1

You can turn the where clause into a method on your News model:

class News
  def self.for_section(section)
      where(section == "all" ? nil : {:section => section})
  end
end

Then in your controller, you can chain it all together like so:

News.for_section(params[:section]).all_active

This of course assumes that all_active is also a scope, and not a resultset.

answered Oct 12, 2010 at 17:10

Jacob

23.2k8 gold badges43 silver badges55 bronze badges

Collectives™ on Stack Overflow

Common refactoring pattern for Rails model

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related