JavaScript variable not defined error?

Question

We have three JS files:

<script type="text/javascript" src="js/pm.init.js"></script> 
<script type="text/javascript" src="js/pm.util.func.js"></script> 
<script type="text/javascript" src="js/pm.nav.js"></script>

In init.js we have:

$(function(){
    var dirty = false;
})

In util.func.js we have:

function dirtyCheck(actionFunction) {
    if (dirty == false) {
        actionFunction();
        return;
    }
    ...

And in nav.js we have:

$(function(){
    $('#btn-nav-refresh').click(function() {
        dirtyCheck(function() { doRefresh(); });
    });
    ...

Now when the btn-nav-refresh function fires after a user clicks the button we get a dirty is not defined error. Why is this??

Just remove the var before dirty = false.

casablanca
– casablanca

2010-10-12 19:33:26 +00:00
Commented Oct 12, 2010 at 19:33 — casablanca
– casablanca, Commented Oct 12, 2010 at 19:33

Pointy · Accepted Answer · 2010-10-12 19:30:28Z

5

I feel dirty myself telling you how to make your "dirty" variable into a dirty global variable, but it'd be like this:

$(function(){
  window.dirty = false;
})

You should however find a better way to do this. Here's an idea:

$(function() {
  $('body').data('dirty', false);
});

Then:

// ...
if (${'body').data('dirty')) takeBath();

answered Oct 12, 2010 at 19:30

Pointy

415k62 gold badges600 silver badges631 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Crackerjack · Accepted Answer · 2010-10-12 19:29:46Z

2

In init.js can't you just put var dirty = false; as a global variable and not inside a function definition?

answered Oct 12, 2010 at 19:29

Crackerjack

2,1543 gold badges28 silver badges36 bronze badges

Comments

Arnaud F. · Accepted Answer · 2010-10-12 19:30:02Z

2

The variable dirty is only known in your closure. That's why.

$(function(){
    var dirty = false;
});
alert(dirty); // Undefined (same file, just one line after.

It's the main feature of the closure...

answered Oct 12, 2010 at 19:30

Arnaud F.

8,51212 gold badges58 silver badges104 bronze badges

Comments

Ender · Accepted Answer · 2010-10-12 19:32:28Z

2

As others have noted, dirty is out of scope because it is enclosed by your document ready function. Change your declaration to be like this instead:

var dirty = false;
$(function(){

});

answered Oct 12, 2010 at 19:32

Ender

15.3k8 gold badges38 silver badges51 bronze badges

Collectives™ on Stack Overflow

JavaScript variable not defined error?

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related