Issue testing null check using NUnit

Question

I am a junior dev that is new to unit testing. My company uses NUnit and I am trying to test a null check in a service method I created. Any idea what my Assert statement should look like if I am trying to test if string acctName = "" ? For some reason string acctName is getting compiler error that says

"The name does not exist in the current context."

MY METHOD:

public Dict getOrder(Client client)
{
    string acctName = client != null ? client.AccountName : "";

    Dict replacements = new Replacement
    {
        {COMPANY_NAME, acctName}
    };
    return new Dict(replacements);
}

MY TEST:

public void getOrderNullTest()
{

    //Arrange

    Client myTestClient = null;

    //Act

    contentService.getOrder(myTestClient);

    //Assert

    Assert.AreEqual(string acctName, "");

}

Also, what is the type of Client.AccountName? Are you sure it's string, and that the property is defined by the class? — hatchet - done with SOverflow
– hatchet - done with SOverflow, Commented Aug 31, 2016 at 19:29
Added the error and yes I am positive it is type string thanks to visual studio ;) — Dean Friedland
– Dean Friedland, Commented Aug 31, 2016 at 19:31
First, I did not down vote your question. Second, This question was caused by a problem that can no longer be reproduced or a simple typographical error. While similar questions may be on-topic here, this one was resolved in a manner unlikely to help future readers. which usually leads to votes to close these as off topic. — Nkosi
– Nkosi, Commented Sep 1, 2016 at 2:12
While you eventually answered your own question and got it to work, know that the issue was that in calling the assert you have Assert.AreEqual(string acctName, "") which is a syntax error, string acctName which is for when you are defining a method, not trying to call it. Hope that helps. — Nkosi
– Nkosi, Commented Sep 1, 2016 at 2:16

Nkosi · Accepted Answer · 2016-09-01 02:29:11Z

1

I ended up writing it like this:

//Arrange

Client myTestClient = null;
string expectedValue = String.Empty;
string expectedKey = COMPANY_NAME;

//Act

Dict actual = contentService.getOrder(myTestClient);

//Assert

Assert.IsTrue(actual.ContainsKey(expectedKey));
Assert.IsTrue(actual.ContainsValue(expectedValue));

edited Sep 1, 2016 at 2:29

Nkosi

249k38 gold badges472 silver badges506 bronze badges

answered Aug 31, 2016 at 20:12

Dean Friedland

7933 gold badges16 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nkosi · Accepted Answer · 2016-09-01 02:32:54Z

0

While you eventually answered your own question and got it to work, know that the issue was that in calling the assert you have Assert.AreEqual(string acctName, "") which has a syntax error, string acctName which is for when you are defining a method, not trying to call it.

Here is another way you could have written it

//Arrange
Client myTestClient = null;
string expectedValue = String.Empty;
string expectedKey = COMPANY_NAME;

//Act
Dict result = contentService.getOrder(myTestClient);

//Assert
Assert.IsNotNull(result);

string actualValue = result[expectedKey];

Assert.IsNotNull(actualValue);
Assert.AreEqual(expectedValue, actualValue);

edited Sep 1, 2016 at 2:32

answered Sep 1, 2016 at 2:25

Nkosi

249k38 gold badges472 silver badges506 bronze badges

3 Comments

Dean Friedland Over a year ago

Thanks for the answer and explanation @Nkosi but why is expectedKey in brackets in string actualValue = result[expectedKey]; ?

Nkosi Over a year ago

The assumption was that Dict was of type Dictionary which would allow an indexed call with the key that returns the value stored at that key.

Dean Friedland Over a year ago

I just learned something new. :) I thought an index call had to reference the index number to get the value, like [0] or [1]

Collectives™ on Stack Overflow

Issue testing null check using NUnit

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related