TypeError: callback.apply is not a function (Node.js & Mongodb)

Question

When I add the line "{ upsert: true }", I got this error:

TypeError: callback.apply is not a function

// on routes that end in /users/competitorAnalysisTextData
// ----------------------------------------------------

router
  .route('/users/competitorAnalysisTextData/:userName')

  // update the user info (accessed at PUT http://localhost:8080/api/users/competitorAnalysisTextData)
  .post(function (req, res) {
    // use our user model to find the user we want
    User.findOne({userName: req.params.userName}, function (err, user) {
      if (err) res.send(err);

      console.log(
        'user.competitorAnalysis.firstObservation: %@',
        user.competitorAnalysis.firstObservation,
      );
      // Got the user name
      var userName = user.userName;
      // update the text data
      console.log('Baobao is here!');
      user.update(
        {
          userName: userName,
        },
        {
          $set: {
            'competitorAnalysis.firstObservation': req.body.firstObservation,
            'competitorAnalysis.secondObservation': req.body.secondObservation,
            'competitorAnalysis.thirdObservation': req.body.thirdObservation,
            'competitorAnalysis.brandName': req.body.brandName,
            'competitorAnalysis.productCategory': req.body.productCategory,
          },
        },
        {upsert: true},
      );

      // save the user
      user.save(function (err) {
        if (err) return res.send(err);

        return res.json({message: 'User updated!'});
      });
    });
  });

Without this line, there is no error. I'm new to nodejs, not very sure where the problem is.

Update

No error message now, but this part of the database is not updated with new data. The embedded document is still empty.

// on routes that end in /users/competitorAnalysisTextData
// ----------------------------------------------------
router
  .route('/users/competitorAnalysisTextData/:userName')

  // update the user info (accessed at PUT http://localhost:8080/api/users/competitorAnalysisTextData)
  .post(function (req, res) {
    console.log('1');

    // Just give instruction to mongodb to find document, change it;
    // then finally after mongodb is done, return the result/error as callback.
    User.findOneAndUpdate(
      {userName: req.params.userName},
      {
        $set: {
          'competitorAnalysis.firstObservation': req.body.firstObservation,
          'competitorAnalysis.secondObservation': req.body.secondObservation,
          'competitorAnalysis.thirdObservation': req.body.thirdObservation,
          'competitorAnalysis.brandName': req.body.brandName,
          'competitorAnalysis.productCategory': req.body.productCategory,
        },
      },
      {upsert: true},
      function (err, user) {
        // after mongodb is done updating, you are receiving the updated file as callback
        console.log('2');
        // now you can send the error or updated file to client
        if (err) return res.send(err);

        return res.json({message: 'User updated!'});
      },
    );
  });

vdj4y · Accepted Answer · 2016-09-02 22:40:28Z

11

There are 2 ways to update documents in mongodb:

find the document, bring it to server, change it, then save it back to mongodb.
just give instruction to mongodb to find document, change it; then finally after mongodb is done, return the result/error as callback.

In your code, you are mixing both methods.

with user.save(), first you search the database with user.findOne, and pull it to server(nodejs), now it lives in your computer memory. then you can manually change the data and finally save it to mongodb with user.save()

User.findOne({ userName: req.params.userName}, function(err, user) {

    if (err)
        res.send(err);

    //this user now lives in your memory, you can manually edit it
    user.username = "somename";
    user.competitorAnalysis.firstObservation = "somethingelse";

    // after you finish editing, you can save it to database or send it to client
     user.save(function(err) {
        if (err)
            return res.send(err);

        return res.json({ message: 'User updated!' });
    });

the second one is to use User.findOneAndUpdate().. This is preferred, instead of user.findOne() then user.update(); because those basically searching the database twice. first to findOne(), and search again to update()

Anyway,the second method is telling mongodb to update the data without first bringing to server, Next, only after mongodb finish with its action, you will receive the updated-file (or error) as callback

User.findOneAndUpdate({ userName: req.params.userName}, 
            {
             $set: { "competitorAnalysis.firstObservation" : req.body.firstObservation,
                      "competitorAnalysis.secondObservation" : req.body.secondObservation,
                      "competitorAnalysis.thirdObservation" : req.body.thirdObservation,
                      "competitorAnalysis.brandName" : req.body.brandName,
                      "competitorAnalysis.productCategory" : req.body.productCategory
            } },
            { upsert: true },
        function(err, user) {
        //after mongodb is done updating, you are receiving the updated file as callback    

        // now you can send the error or updated file to client
        if (err)
            res.send(err);

        return res.json({ message: 'User updated!' });
        });

edited Sep 2, 2016 at 22:40

answered Sep 2, 2016 at 19:51

vdj4y

2,6692 gold badges24 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Chenya Zhang Over a year ago

I think you explain very well and try to follow the second suggested way. However, I still get the same error message. Could you please help me a little bit more and have a look at my Update section in the post?

vdj4y Over a year ago

I hope this one works, actually you passed 5 arguments, findOneAndUpdate() accept 4 arguments. The 4th is the callback mongoosejs.com/docs/api.html#query_Query-findOneAndUpdate

Chenya Zhang Over a year ago

Yes, very helpful.

Chenya Zhang Over a year ago

Sorry... there is no error message now. But this part of the database is still not updated with new data. The embedded document is still empty. The Update is the latest...

vdj4y Over a year ago

I am not sure, the code seems correct, with {upsert: true}, you are telling mongodb to create new document if the query does not match anything.. maybe you can log the error, or try to $set one document to check any error

|

Anhdevit · Accepted Answer · 2020-10-07 03:29:42Z

2

You forgot to pass a callback to the update method

user.update(
  {
    $set: {
      'competitorAnalysis.firstObservation': req.body.firstObservation,
      'competitorAnalysis.secondObservation': req.body.secondObservation,
      'competitorAnalysis.thirdObservation': req.body.thirdObservation,
      'competitorAnalysis.brandName': req.body.brandName,
      'competitorAnalysis.productCategory': req.body.productCategory,
    },
  },
  {upsert: true},
  function (err, result) {},
);

update method expects 3 arguments.

document update
options
callback

edited Oct 7, 2020 at 3:29

Anhdevit

2,0683 gold badges19 silver badges36 bronze badges

answered Sep 2, 2016 at 19:51

Ebrahim Pasbani

9,4062 gold badges26 silver badges32 bronze badges

2 Comments

Chenya Zhang Over a year ago

I still find the same error after adding the callback. Could you please see the Update section in my post?

Ebrahim Pasbani Over a year ago

@ChenyaZhang You pass extra arguments to that function. Check it out

Collectives™ on Stack Overflow

TypeError: callback.apply is not a function (Node.js & Mongodb)

2 Answers 2

6 Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

6 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related