PHP While Loop for Multidimensional Arrays

Question

So i tried to loop through bunch of arrays using the while loop. So it does not work like this, how does it work?

    while($x<$sQuery($SERVER)['number'])
    {
        $o = $o . "<Server>
      <Name>".$sQuery($SERVER)[$x]['name']."</Name>
      <DNS>".$sQuery($SERVER)[$x]['ip']."</DNS>
    <Lat>0</Lat>
      <Long>0</Long>
      <Usage>-1</Usage>
      <RankRequired>0</RankRequired>
    </Server>"
        x++;
    }
}

The error is in this line(s):

      <Name>".$sQuery($SERVER)[$x]['name']."</Name>
      <DNS>".$sQuery($SERVER)[$x]['ip']."</DNS>

The [$x] is not allowed and i do not know how i can loop through them, any ideas?

where's the semicolon after the </Server>" ? also, what is "x++"; ? maybe $x++; ? — Oleg Dubas
– Oleg Dubas, Commented Sep 2, 2016 at 20:28
I don't recomment using $sQuery($SERVER). This is running that function over and over, every iteration. Better do it once before the loop and just use it statically. — Oleg Dubas
– Oleg Dubas, Commented Sep 2, 2016 at 20:31
What version of PHP are you running? You need to be running PHP 5.4 or later to use an index after a function call. See stackoverflow.com/questions/10767976/… — Barmar
– Barmar, Commented Sep 2, 2016 at 20:40

Death-is-the-real-truth · Accepted Answer · 2016-09-06 08:37:14Z

1

I would rewrite it this way:-

$s = $sQuery($SERVER);

for($i=0; $i<$s['number']; $i++)
{
    $o .= "<Server><Name>".$s[$i]['name']."</Name>
           <DNS>".$s[$i]['ip']."</DNS><Lat>0</Lat><Long>0</Long><Usage>-1</Usage>
           <RankRequired>0</RankRequired></Server>";
}

edited Sep 6, 2016 at 8:37

Death-is-the-real-truth

72.3k10 gold badges59 silver badges105 bronze badges

answered Sep 2, 2016 at 20:36

Oleg Dubas

2,3481 gold badge12 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Barmar Over a year ago

Why not use foreach?

Oleg Dubas Over a year ago

@Barmar Because there are the elements he needs AND the ["number"] element on the same level. You can go with foreach but you will have to ignore the "number" key then, an extra line.

Death-is-the-real-truth · Accepted Answer · 2016-09-06 08:37:30Z

1

So, I'm answering my own question (kinda). The comments helped me a lot. The thing is.. i should go to sleep because i am too tired for programming.

function ListServersXML($SERVER)
{
    $x = 0;
    $o = "";
    $s = sQuery($SERVER);
    while($x<$s['number'])
    {
        $o = $o . "<Server>
      <Name>".$s[$x]['name']."</Name>
      <DNS>".$s[$x]['ip']."</DNS>
    <Lat>0</Lat>
      <Long>0</Long>
      <Usage>-1</Usage>
      <RankRequired>0</RankRequired>
    </Server>";
        $x++;
    }
    return $o;
}

(btw this is my full function)

edited Sep 6, 2016 at 8:37

Death-is-the-real-truth

72.3k10 gold badges59 silver badges105 bronze badges

answered Sep 2, 2016 at 20:31

user6262603

3 Comments

Death-is-the-real-truth Over a year ago

it's your responsibility to provide full code. It's not a good practice to hide code and then answer your question itself by showing full code (while others comment and answer resolved your problem)

Barmar Over a year ago

Why don't you want to use foreach?

Oleg Dubas Over a year ago

@Barmar as I already said, he has the elements he needs AND the ["number"] element on the same level. You can go with foreach but you will have to ignore the "number" key then, an extra line.

Collectives™ on Stack Overflow

PHP While Loop for Multidimensional Arrays

2 Answers 2

2 Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related