Why wont it loop? (PHP and MySQL)

Question

I wrote this code:

<?php
mysql_connect("localhost", "root", "root") or
    die("Could not connect: " . mysql_error());
mysql_select_db("internal");

$result = mysql_query("SELECT Title, Message FROM msg");
?>

<?php

  while ($row = mysql_fetch_array($result, MYSQL_NUM)){
?>

     <div>
         <h3><a href="#"><?php printf("%s", $row[0]); ?></a></h3>
         <div><?php printf("%s", $row[1]); ?></div>
     </div>

<?php
 mysql_free_result($result);
  }
?>

The result I´m getting is the first row of the MySQL table (With the correct formatting) I include an Image just in case:

screeshot result

(This is in fact the first row of my MySQL DB and the only thing I see)

The code was looping until I had to add the html tags, what I mean is that if I just do:

<?php printf("%s", $row[0]); ?>
&
<?php printf("%s", $row[1]); ?>

It looped and brought all of the results.

Could this be a syntax error?

Thanks to all! The problem is definitely solved!

Trufa
– Trufa

2010-10-14 16:06:23 +00:00
Commented Oct 14, 2010 at 16:06 — Trufa
– Trufa, Commented Oct 14, 2010 at 16:06

Tarka · Accepted Answer · 2010-10-14 15:58:33Z

5

mysql_free_result($result); inside your while loop. This makes it so after the first iteration, it clears the results, making so no more can be grabbed.

Change your ending to

<?php
  }
mysql_free_result($result);
?>

and it'll fix it

answered Oct 14, 2010 at 15:58

Tarka

4,0432 gold badges25 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ignacio Vazquez-Abrams · Accepted Answer · 2010-10-14 15:56:58Z

2

Your third-to-last line frees the result before you're done with it. Move it outside the loop.

answered Oct 14, 2010 at 15:56

Ignacio Vazquez-Abrams

804k160 gold badges1.4k silver badges1.4k bronze badges

Comments

stew · Accepted Answer · 2010-10-14 15:57:27Z

1

move the call to mysql_free_result to be outside of the while loop.

answered Oct 14, 2010 at 15:57

stew

11.4k39 silver badges49 bronze badges

Comments

egis · Accepted Answer · 2010-10-14 16:04:33Z

1

You are freeing result after the first loop. Here

mysql_free_result($result);
 }

This should be

  }
mysql_free_result($result);

edited Oct 14, 2010 at 16:04

answered Oct 14, 2010 at 15:58

egis

1,4022 gold badges11 silver badges24 bronze badges

Comments

Johan · Accepted Answer · 2010-10-14 15:57:44Z

0

Doesn't mysql_free_result clear the result set?

You have nothing left to loop over!

answered Oct 14, 2010 at 15:57

Johan

4055 silver badges14 bronze badges

Collectives™ on Stack Overflow

Why wont it loop? (PHP and MySQL)

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related