How to store a string from a text file in an array in C

Question

I want to read a text file into a string array and be able to access the array contents through a loop. The code I have allows me to store only the last line of the text file instead of the entire file; where am I going wrong?

#define MAX 10000

int main (int argc, char *argv[])
{
    FILE *fp;
    char str[MAX];
    char *x[MAX];
    int i =0;
    char y[MAX];

    if((fp = fopen("550.txt", "r"))==NULL) {
    printf("Cannot open file.\n");
    exit(1);}

    while(!feof(fp)) {
        while(fgets(str, sizeof str, fp)) {
            x[i]= str;
            printf("%s", str);
            printf("%s", *(x+i));
            i++;
        }
  }


for(i=0;i<100;i++){
    printf("%s", *(x+i));
}

   fclose(fp);

  return 0;
}

Don't use feof() to control loop cond.c-faq.com/stdio/feof.html — Nyan
– Nyan, Commented Oct 14, 2010 at 18:27

Richard Cook · Accepted Answer · 2010-10-14 20:35:17Z

3

You only allocate one string array str. At each iteration through the loop you are simply overwriting str. The assignment x[i] = str assigns the pointer value of str to x[i]. You'll notice that each member of the array x points to the same buffer str at the end of the loop. You need to create multiple buffers.

One way to do this is to define the maximum number of lines using #define LINES 100 and then to declare x as follows

char x[LINES][MAX];

and then perform a strcpy at each iteration:

while(fgets(str, sizeof str, fp)) {
    strcpy(x[i], str);
    printf("%s", str);
    printf("%s", *(x+i));
    i++;
}

Note that you should consider using the strncpy method instead of strcpy and check the return value to ensure that the buffers do not overrun.

edited Oct 14, 2010 at 20:35

answered Oct 14, 2010 at 18:00

Richard Cook

33.2k6 gold badges49 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Nyan Over a year ago

Are you sure that fgets will not zero-terminate the buffer for long input?

RichieHindle · Accepted Answer · 2010-10-14 18:01:32Z

1

You need to make a copy of each string:

x[i] = strdup(str);

What you're doing at the moment is making each x[i] point to the same buffer, which will contain the last line of the file once you've finished.

(Note: you'll also need to free() all of the x[i] strings you create with strdup().)

answered Oct 14, 2010 at 18:01

RichieHindle

283k49 gold badges367 silver badges408 bronze badges

Comments

pm100 · Accepted Answer · 2010-10-14 18:02:49Z

0

you are not stroing the line you read anywhere. It is buffered into str but the you overwrite it with the next line. use strdup.

x[i] = strdup(str);

answered Oct 14, 2010 at 18:02

pm100

50.6k25 gold badges95 silver badges158 bronze badges

Collectives™ on Stack Overflow

How to store a string from a text file in an array in C

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related