c++ Multidimensional array wont initialize

Question

I have been trying to get this to work correctly; however it seems I can not figure this out. I am trying to get a game board to initialize correctly but it keeps saying that <error reading characters of string>.

using namespace std;

int main()
{

    board show;
    show.init();
    show.printing();

}


class board {

public:
    void init(){

        string Board[8][9] = {
            { "C56", "C15", "C21", "C62", "C11", "C62", "C21", "C15", "C56" },
            { " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 " },
            { " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 " },
            { " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 " },
            { " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 " },
            { " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 " },
            { " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 " },
            { "C56", "C15", "C21", "C62", "C11", "C62", "C21", "C15", "C56" },
        };
    }

    void printing(){

        string character = "*";

        int position[2] = { 2, 2 };
        // Draw the grid once
        for (int i = 0; i < 8; i++){
            for (int j = 0; j < 9; j++){
                if (i == position[0] && j == position[1])
                    cout << character;
                else
                    cout <<  Board[8][9];
                cout << " ";
            }
            cout << endl;
        }
    }

private:
    string Board[8][9];
};

cout << Board[8][9]; uses two invalid indices. You probably mistyped cout << Board[i][j];. — molbdnilo
– molbdnilo, Commented Sep 14, 2016 at 0:19

Raindrop7 · Accepted Answer · 2016-09-14 00:44:07Z

it's so easy: you have the half solution: just use for loop to copy values

void A::init()
{
    string Board[8][9] = {
        { "C56", "C15", "C21", "C62", "C11", "C62", "C21", "C15", "C56" },
        { " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 " },
        { " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 " },
        { " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 " },
        { " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 " },
        { " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 " },
        { " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 ", " 0 " },
        { "C56", "C15", "C21", "C62", "C11", "C62", "C21", "C15", "C56" },
    };

    for(int i(0); i < 8; i++)
    {
        for(int j(0); j < 9; j++)
            this->Board[i][j] = Board[i][j];        
    }
}

Jezor · Accepted Answer · 2016-09-14 00:19:07Z

0

In the init method you created a new, local variable. You are not referring to your instance variable, therefore in printing method the variable is not initialized.

Instead of

string Board[8][9] = // ... initialization code

you should write

this->Board = // ... initialization code

or just

Board = // ... initialization code

You can read more about variable types here.

edited Sep 14, 2016 at 0:19

answered Sep 14, 2016 at 0:06

Jezor

3,4363 gold badges21 silver badges47 bronze badges

6 Comments

Peter Over a year ago

The use of this is not required (it is implied). But if you are going to use it, it is a pointer not a reference.

Jezor Over a year ago

@Peter true, too much Java lately (;

Peter Over a year ago

My condolences.

skipper Over a year ago

@Jezer Thank you, now I am getting the error: Expression must be a modifiable lvalue. Any tips to fix that?

molbdnilo Over a year ago

You can't assign to arrays.

|

Collectives™ on Stack Overflow

c++ Multidimensional array wont initialize

2 Answers 2

Comments

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related