Replace within a string, Javascript

Question

I am having some issues with the simple .replace() function from JS.

Here is my code

    console.log(URL);
    URL.replace("-","/");
    console.log(URL);

Here is my output:

folder1-folder2-folder3 folder1-folder2-folder3

the second one should be

folder1/folder2/folder3

right?

If you guys need from my code, please let me know :)

Thanks in advance,

Bram

Possible duplicate of Replacing all occurrences of a string in JavaScript. — Álvaro González
– Álvaro González, Commented Sep 14, 2016 at 12:10
"The replace() method returns a new string with some or all matches of a pattern replaced by a replacement." — epascarello
– epascarello, Commented Sep 14, 2016 at 12:14

pachonjcl · Accepted Answer · 2016-09-14 12:17:35Z

3

The correct thing is to replace it with a global regex with g after the regex that in this case is /-/

console.log(URL);
URL = URL.replace(/-/g,"/");
console.log(URL);

answered Sep 14, 2016 at 12:17

pachonjcl

7414 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

B.Wesselink Over a year ago

Hmm, it worked, why didnt Rajesh option worked? And why does it work like you say? What does the "regex" do?

pachonjcl Over a year ago

regex is a regular expression that matchs patterns and with string replace method you can replace any ocurrence with something that you want, g regex modifier is to match all the ocurrence while normally would replace only the first one Check this

Community · Accepted Answer · 2017-05-23 10:29:14Z

3

Replace returns a new string after replacement. It does not alter the string that replace was called on. Try this:

console.log(URL);
URL = URL.replace("-","/");
console.log(URL);

To replace all occurences look at this How to replace all occurrences of a string in JavaScript?

console.log(URL);
URL = URL.replace(/-/g, '/');
console.log(URL);

edited May 23, 2017 at 10:29

CommunityBot

11 silver badge

answered Sep 14, 2016 at 12:11

osjo

1316 bronze badges

3 Comments

B.Wesselink Over a year ago

Some progress, but now I get: folder1/folder2-folder3

Rajesh Dixit Over a year ago

@B.Wesselink you will have to use regex. URL = URL.replace(/-/g,"/");

B.Wesselink Over a year ago

Now I get an "undefined"

Collectives™ on Stack Overflow

Replace within a string, Javascript

2 Answers 2

2 Comments

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related