php echo link with variables from database

Question

Im trying to link to a post with variables from my database, i guess im missing some ' or something... cant get it right it seems. Anyone here that got any idea?

<?php
require_once 'includes/conn.php';
try{ 
    $conn = new PDO("mysql:dbname=$db;host=$server;port=$port","$user","$pass");
    $conn->setAttribute( PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION );
    $sql = "SELECT * FROM $table WHERE NOT forum_id = 2 ORDER BY topic_id desc";
    $stmt = $conn->prepare($sql);
    $stmt->execute ();
    foreach ($conn->query($sql) as $post) { 
         echo '<a href="http://forum.mysite.com/viewtopic.php?f='.$post[forum_id].'&t='.$post[topic_id].'">', $post[subject], '</a>';
    }
}catch (PDOException $e) {
    print "Error!: " . $e->getMessage() . "<br/>";
    die();
}
$conn=null;
?>

This is the problem:

echo '<a href="http://forum.mysite.com/viewtopic.php? f='.$post[forum_id].'&t='.$post[topic_id].'">', $post[subject], '</a>';

the link should look something like this:
http://forum.mysite.com/viewtopic.php?f=12&t=12

And what is the link it is giving...?

Ankur Pathak
– Ankur Pathak

2016-09-20 19:25:28 +00:00
Commented Sep 20, 2016 at 19:25 — Ankur Pathak
– Ankur Pathak, Commented Sep 20, 2016 at 19:25
You have an extra space between ? and f=.

Barmar
– Barmar

2016-09-20 19:31:14 +00:00
Commented Sep 20, 2016 at 19:31 — Barmar
– Barmar, Commented Sep 20, 2016 at 19:31
it is just blank :/

per källström
– per källström

2016-09-20 19:33:31 +00:00
Commented Sep 20, 2016 at 19:33 — per källström
– per källström, Commented Sep 20, 2016 at 19:33

ScaisEdge · Accepted Answer · 2016-09-20 19:28:15Z

1

You should use . for concatenation (not comma)

echo '<a href="http://forum.mysite.com/viewtopic.php?f='. 
  $post[forum_id].'&t='.$post[topic_id].'">' .  
      $post[subject]  .'</a>';

and remove the blank between ? and f

edited Sep 20, 2016 at 19:28

answered Sep 20, 2016 at 19:19

ScaisEdge

134k10 gold badges98 silver badges111 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

ScaisEdge Over a year ago

are you sure you have proper value in the the vars ... update the your question and show the actual result using var_dump('<a href="forum.mysite.com/viewtopic.php? f='. $post[forum_id].'&t='.$post[topic_id].'">' . $post[subject] .'</a>')

Barmar Over a year ago

comma can be used to separate multiple arguments to echo.

per källström Over a year ago

sigh... subject shou've been post_subject /facepalm

ScaisEdge Over a year ago

@perkällström what in var_dump ?.. update your question and show me .. the result

Collectives™ on Stack Overflow

php echo link with variables from database

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related