Coverting same named function into single function using cascading in Java

Question

Is there any way to convert below function into one function in Java ? I tried cascading it using (TestRow ) but that doesn't work.

public void testWindow (TestRow window, String title) {
    if (window != null) {
        try {
            window.zClose(window);
        } catch (HarnessException e) {
            e.printStackTrace();
        }
        window = null;
    }
}

public void testWindow (TestColumn window, String title) {
    if (window != null) {
        try {
            window.zClose(window);
        } catch (HarnessException e) {
            e.printStackTrace();
        }
        window = null;
    }
}

Here TestRow and TestColumn is custom types.

Calling would be same way but due to custom window names, i need to copy paste same function many times which i think can be avoidable.

Do TestColumn and TestRow have common interface / abstract class to which method zClose belongs? — Andrii Abramov
– Andrii Abramov, Commented Sep 23, 2016 at 21:10

Andriy Kryvtsun · Accepted Answer · 2016-09-23 21:12:16Z

3

Extract your common logic in a separate method with common windows class as a parameter and call this common method in many places. E.g.

public void testWindow (TestRow window, String title) {
    closeWindow(window);
}

public void testWindow (TestColumn window, String title) {
    closeWindow(window);
}

private void closeWindow(CommonWindowsClass window) {
    if (window != null) {
        try {
            window.zClose(window);
        } catch (HarnessException e) {
            e.printStackTrace();
        }
        window = null;
    }
}

Here CommonWindowsClass is superclass both for TestRow and TestColumn classes.

UPDATE also I suppose you actually don't need this code line window = null; at all

answered Sep 23, 2016 at 21:12

Andriy Kryvtsun

3,3933 gold badges33 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jitesh Sojitra Over a year ago

Thanks Andriy for the help!

davidbuzatto · Accepted Answer · 2016-09-23 21:11:30Z

2

You can use inheritance. Something like:

public abstract class Test {
    public abstract void zClose( Teste t );
}

public class TestRow extends Test {
    @Override
    public void zClose( Test t ) {
         // code...
    }
}

public class TestColumn extends Test {
    @Override
    public void zClose( Test t ) {
         // code...
    }
}

public void testWindow (Test window, String title) {
    if (window != null) {
        try {
            window.zClose(window);
        } catch (HarnessException e) {
            e.printStackTrace();
        }
        window = null;
    }
}

answered Sep 23, 2016 at 21:11

davidbuzatto

9,4841 gold badge48 silver badges52 bronze badges

1 Comment

Jitesh Sojitra Over a year ago

Thanks David for the help!

Collectives™ on Stack Overflow

Coverting same named function into single function using cascading in Java

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related