Dynamically update a php array with a function

Question

I have multiple sitemaps and I would like to merge them all, but before merging them, I need to append a unique variable to all values in all arrays.

// The global variable
define("BASE_URL", "http://domain.com");
$sitemap_full = [ "home" => BASE_URL ];

// One of the arrays
$sitemap_example = [
  "foo" => "/bar",
  "gnu" => "/lar"
];

Since I have multiple of those arrays, I wanted to create a function that will append the link.

function pushToSitemap($initial_sitemap, $sitemap) {
    foreach ($initial_sitemap as $title => $url) {
      return $sitemap[$title] = BASE_URL . $url;
    }
}

And in action in will be:

pushToSitemap($sitemap_example, $sitemap_full);

But this just doesn't work because if I print_r($sitemap_full); it will display Array( "home", "http://domain.com" );.

What really annoys me is that if in the function I echo them, they will be echoed.

What am I doing wrong?

EDIT

It should display

Array(
  "home" => "http://domain.com"m
  "foo" => "http://domain.com/bar",
  "gnu" => "http://domain.com/lar
);

you're returning inside the very first iteration of foreach in your pushToSitemap() function, so it never continues iterating; only return after the foreach loop terminates — Mark Baker
– Mark Baker, Commented Sep 27, 2016 at 23:22
That ^^^^ and then maybe you should show us what you want the array to look like after you have fiddled with it, as its not exactly obvious to me — RiggsFolly
– RiggsFolly, Commented Sep 27, 2016 at 23:23
var_dump(array_merge($sitemap_full, array_map(function($value) {return BASE_URL . $value; }, $sitemap_example))); — Mark Baker
– Mark Baker, Commented Sep 27, 2016 at 23:32

ctrlmaniac · Accepted Answer · 2016-09-27 23:47:22Z

1

Your problem seems lie inside your foreach function:

function pushToSitemap($initial_sitemap, $sitemap) {
    foreach ($initial_sitemap as $title => $url) {
      return $sitemap[$title] = BASE_URL . $url;
    }
}

You are returning just a single item, what's more, the formatting is off.

Instead,

function pushToSitemap($initial_sitemap, $sitemap) {
    foreach ($initial_sitemap as $title => $url) {
      $sitemap[$title] = BASE_URL . $url;
    }
    return $sitemap;
}

$sitemap_full = pushToSitemap($sitemap_example, $sitemap_full);

edited Sep 27, 2016 at 23:47

ctrlmaniac

4744 gold badges16 silver badges31 bronze badges

answered Sep 27, 2016 at 23:23

Derek Pollard

7,1856 gold badges45 silver badges62 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Dawid Zbiński Over a year ago

I guess he doesn't even want to return anything and just do the action so the Sitemaps are "refreshed".

Derek Pollard Over a year ago

@DawidZbiński - how do you figure?

Dawid Zbiński Over a year ago

Ok, my bad. Now I realized that he wants to merge them.

Derek Pollard Over a year ago

@dcdeiv you have to reset the $sitemap_full variable to the contents of the function: $sitemap_full = pushToSitemap($sitemap_example, $sitemap_full);

Collectives™ on Stack Overflow

Dynamically update a php array with a function

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related