Showing multiple queries in foreach in Laravel

Question

I have a query that take 10 ids, then I'm looping thorugh those id's, using foreach to execute seperate queries for each id. But I'm getting more queries, for each loop it's adding previous ones too, I don't get why. I use Laravel 5.

foreach($data as $id)
{
     $query = (new TestModel)->newQuery();
     $query->where('Test.ID', '=', $id);
}

When I get query log, for first loop I have one query, for second loop I have two queries and so on. But when I just echo $id, it's showing exactly right number of ids.

Vikash · Accepted Answer · 2016-09-28 11:12:09Z

2

I will suggest you to use whereIn() of laravel query builder

// It will give you all queries
$allQueries = TestModel::whereIn('id',$data)->get();

then you can iterate throught foreach to get your query

foreach($allQuery as $query)
{ 
 // Here $query will return single object of TestModel
 // do your stuff here.
}

For your question what we discussed in comment. Try this

$allQueries = TestModel::whereIn('id',$data)->get();
$groupByQuery = collect($allQueries)->groupBy('date')->toArray();

return $groupByQuery;

see is it returning what you want.?

edited Sep 28, 2016 at 11:12

answered Sep 28, 2016 at 8:20

Vikash

3,5843 gold badges25 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Lusine Martirosyan Over a year ago

but this doenst work for me, for your example is working,but I'm adding groub by and in this case it's working wrong.I think I need to write query inside foreach for grouping data and taking whatever I want

Lusine Martirosyan Over a year ago

No, this will group for all rows, but I need to group by each id's date

Vikash Over a year ago

If you will fetch TestModel::where('id',$id)->get(); then it will return single result, right ? but groupBy is used on more than one results like array or array of objects, then how you want to implement it for a single result.?

Vikash Over a year ago

@LusineMartirosyan Try this. If it doesn't work then you can email me your DB tables schema and your exact problem at [email protected]

Doom5 · Accepted Answer · 2016-09-28 08:15:37Z

1

Move your your instantiation of $query outside your loop.

$query = (new TestModel)->newQuery();
foreach($data as $id)
{
     $query->where('Test.ID', '=', $id);
}

Or better, just use whereIn:

$query = (new TestModel)->newQuery()->whereIn('Test.ID', $data);

You don't even need to instantiate a new model:

$query = TestModel::whereIn('Test.ID', $data);

answered Sep 28, 2016 at 8:15

Doom5

8589 silver badges18 bronze badges

Comments

P.Mantello · Accepted Answer · 2016-09-28 08:08:28Z

0

Guess you should add

unset($query);

As you create a new query everytime.

answered Sep 28, 2016 at 8:08

P.Mantello

295 bronze badges

1 Comment

Lusine Martirosyan Over a year ago

Thanks for your answer, but the same. It's showing multiple queries in debug

Yudi Yohanes Septian Gotama · Accepted Answer · 2016-09-28 08:15:24Z

0

Try using eloquent model:

foreach($data as $id)
{
     $query = TestModel::Where('Test.ID', '=', $id)->get();
}

answered Sep 28, 2016 at 8:15

Yudi Yohanes Septian Gotama

5992 gold badges6 silver badges20 bronze badges

Collectives™ on Stack Overflow

Showing multiple queries in foreach in Laravel

4 Answers 4

4 Comments

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related