Unexpected user input onclick

Question

I can't figure out how to fix this. It says the onclick is missing a semi-colon. I'm sure I'm missing something obvious - any ideas?

<a href="http://mywebsite.com" onclick="setTimeout(location.href='https://www.facebook.com/myprofile', 10);return true;">

Trying to squeeze that much code into an onclick, or arguably even using onclick at all, is your first problem. Move it to the pages script file. — Luke Joshua Park
– Luke Joshua Park, Commented Sep 29, 2016 at 20:43
setTimeout expects to be passed a function. You are passing a string ("https://www.facebook.com/myprofile"), which gets evald as JavaScript code, but that string doesn't contain JavaScript, so an error is thrown. — Felix Kling
– Felix Kling, Commented Sep 29, 2016 at 20:44
Expanding on @LukePark 's comment about onclick - agree, avoid using onclick= and instead learn how to attach event handlers by using addEventListener or with a toolkit such as jQuery. — Stephen P
– Stephen P, Commented Sep 29, 2016 at 20:51

tymeJV · Accepted Answer · 2016-09-29 20:43:43Z

2

Your setTimeout syntax is invalid, it should be:

setTimeout(function() { location.href='https://www.facebook.com/myprofile'; }, 10);

answered Sep 29, 2016 at 20:43

tymeJV

105k14 gold badges165 silver badges158 bronze badges

Sign up to request clarification or add additional context in comments.

1 Answer 1