php use $_Get to include a .php

Question

at the moment a friend and I are working through a PHP tutorial. We are both new to php, but have some general experience in other languages.

We want to include "testseite.php" into our index.php The "testseite.php" is in the folder content/articles

The way the tutorial does it is to use

include("content/articles/".$_GET['include']);

but if we do that there is the following error:

Warning: include(/users/xxx/www/users/xxx/www/myCms/content/articles) [function.include]: failed to open stream: No such file or directory in /users/flateric/www/users/flateric/www/myCms/index.php on line 5

Warning: include() [function.include]: Failed opening 'content/articles/' for inclusion (include_path='.') in /users/xxx/www/users/xxx/www/myCms/index.php on line 5

We thought ourselves that the problem might be, that it doubles the username (i changed it to xxx) and "users" and "www" in the path. Thanks for your help

This is such a bad idea... You're trusting user input to access files — Machavity
– Machavity ♦, Commented Oct 2, 2016 at 21:25
if we manually include it via include("content/articles/testseite.php"); it is correctly displayed — ben1806
– ben1806, Commented Oct 2, 2016 at 21:25
A tutorial showing usage of include() based on a GET variable should be abandoned as soon as possible. — Te Ko
– Te Ko, Commented Oct 2, 2016 at 22:02
Possible duplicate of PHP - Failed to open stream : No such file or directory — Vic Seedoubleyew
– Vic Seedoubleyew, Commented Oct 3, 2016 at 15:54

Panda · Accepted Answer · 2017-09-16 16:14:25Z

2

In PHP, include means to load the file into the arguments, like loading a library. So, this error means the file /users/flateric/www/users/flateric/www/myCms/index.php does not exist. You should evaluate if the $_GET value points to a physical file.

edited Sep 16, 2017 at 16:14

Panda

6,8846 gold badges46 silver badges61 bronze badges

answered Oct 2, 2016 at 21:30

Aina

281 silver badge3 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Michael Gaskill · Accepted Answer · 2016-10-02 23:47:19Z

1

It appears that $_GET['include'] is empty (or the include key is non-existent). This is causing the filename to include to be wrong. You're expecting to include a file named this:

content/articles/testseite.php

but actually getting an include for this:

content/articles/

Clearly, this is incorrect and causes the error. If the $_GET params don't include the include value (or it's blank), you should probably consider another approach, such as providing a default value or generating an error to the user.

answered Oct 2, 2016 at 23:47

Michael Gaskill

8,06210 gold badges40 silver badges46 bronze badges

1 Comment

Vic Seedoubleyew Over a year ago

There is a troubleshooting checklist for this frequent error message : stackoverflow.com/questions/36577020/…

Collectives™ on Stack Overflow

php use $_Get to include a .php

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest