php replace all strings in array, and output comma seperated string

Question

Wrote a little snippet that replaces all strings in an array, and finally outputs them as a comma separated string (shown below).

It seems a bit much though for such simple functionality. So my question is can anyone come up with a more elegant way of writing this?

$arr = array('first', 'second', 'third');
$size = count($arr);
$newArr = array();

for($i=0; $i<$size; $i++) {

    $newArr[$i] = str_replace($arr[$i], '?', $arr[$i]);

}

$final = implode(', ', $newArr);

echo $final;

This question is more suited for Code Review than Stack Overflow. — M. Eriksson
– M. Eriksson, Commented Oct 3, 2016 at 14:53
Isn't the code a bit pointless? I mean it always replaces all of the array elements with "?", because you are passing $arr[$i] as both the needle and input string. — Shira
– Shira, Commented Oct 3, 2016 at 14:53

AbraCadaver · Accepted Answer · 2016-10-03 14:52:45Z

2

str_replace() accepts arrays:

$newArr = str_replace($arr, '?', $arr);
$final = implode(', ', $newArr);

But I hope this was just an example as you are just replacing anything in the array with ? which is easier done.

answered Oct 3, 2016 at 14:52

AbraCadaver

79.2k7 gold badges75 silver badges91 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

vicentimartins · Accepted Answer · 2016-10-03 15:12:01Z

1

An other form to your snippet...

    <?php
       $arr = array('first', 'second', 'third');
       foreach ($arr as $item) {
           $na[] = str_replace($item, '?', $item);
       }
       echo implode(', ', $na);

Hope help you!

answered Oct 3, 2016 at 15:12

vicentimartins

465 bronze badges

Collectives™ on Stack Overflow

php replace all strings in array, and output comma seperated string

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related