PHP Class Updating Array - How to make more efficient

Question

I have the following code and I was wondering how I can edit this so that I can update the array with multiple values with one call of:

$var->updateArray("Value 1", "Value2", "Value 3", and so on.... );

My current code at the moment is:

<?php
class MyClass {
public $myArray = array();

public function updateArray($newValue) {
    $this->myArray[] = $newValue;
}

public function showArray() {
    foreach($this->myArray as $arrayValue) {
        echo "<li>";
        echo $arrayValue;
        echo "</li>";
    }
}

}

$var = new MyClass;

$var->updateArray("Value 1");
$var->updateArray("Value 2");
$var->updateArray("Value 3");

echo $var->showArray();

?>

Poiz · Accepted Answer · 2016-10-07 11:21:23Z

Simply use func_get_args if you wish to pass the other arguments as string values; otherwise pass an Array of values and Process it. The first Idea could be demonstrated with this snippet:

    class MyClass {
        public $myArray = array();

        public function updateArray($newValue) {
            $arguments  = func_get_args();
            if($arguments) {
                foreach ($arguments as $argument) {
                    $this->myArray[] = $argument;
                }
            }
        }

        public function showArray() {
            foreach($this->myArray as $arrayValue) {
                echo "<li>";
                echo $arrayValue;
                echo "</li>";
            }
        }

    }

    $var = new MyClass();

    $var->updateArray("Value 1", "Value2", "Value 3");
    $var->showArray();

The second idea: passing an Array of values could be demonstrated by the snippet below:

    class MyClass {
        public $myArray = array();

        /**
         * UPDATES THE INTERNAL ARRAY USING WHATEVER VALUES PASSED IN AS ARGUMENT(S)
         * IN THIS CASE, YOU COULD PASS AS MANY ARGUMENTS AS YOU WISH AS STRING-VALUES...
         * @param $newValue
         */
        public function updateArray($newValue) {
            $arguments  = func_get_args();
            if($arguments) {
                foreach ($arguments as $argument) {
                    $this->myArray[] = $argument;
                }
            }
        }

        /**
         * UPDATES THE INTERNAL ARRAY USING A COLLECTION: AN ARRAY OF VALUES
         * @param array $collection
         */
        public function updateArrayFromCollection(array $collection) {
            if($collection) {
                foreach ($collection as $value) {
                    $this->myArray[] = $value;
                }
            }
        }

        public function showArray() {
            foreach($this->myArray as $arrayValue) {
                echo "<li>";
                echo $arrayValue;
                echo "</li>";
            }
        }

    }

    $var = new MyClass();

    $var->updateArrayFromCollection(["Value 1", "Value2", "Value 3"]);
    $var->showArray();

Alex Yarygin · Accepted Answer · 2016-10-07 11:10:38Z

1

You could use something like that:

public function updateArray() {
    if (func_num_args() > 0) {
        $args = func_get_args();
        foreach ($args as $arg) {
            $this->myArray[] = $arg;
        }
    }
}

I didn't try the code so it could contains errors.

answered Oct 7, 2016 at 11:10

Alex Yarygin

1147 bronze badges

1 Comment

lky Over a year ago

Thanks :) That Works

abhayendra · Accepted Answer · 2016-10-07 11:13:00Z

0

public function showArray() {
    foreach($this->myArray as $arrayValue) {
        $array_collect[] =  $arrayValue; 
    }
}

Then print

$array = Implode (',',$array_collect);
echo $array;

arrange collection according to use Implode function

answered Oct 7, 2016 at 11:13

abhayendra

1976 bronze badges

Collectives™ on Stack Overflow

PHP Class Updating Array - How to make more efficient

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related