Using my strings in a IF ELSE

Question

I'm a really really noob at coding it's my first program and my first time I touch a coding software.

First let me show you what I have :

private void SaveClose_Click(object sender, RoutedEventArgs e)
{
    using (var fs = new FileStream(@"Resources\arguments.txt", FileMode.Truncate))
    {
    }

    if (Windowed.IsChecked == true)
        windowed = true;
    else
        windowed = false;

    string text = File.ReadAllText(@"Resources\arguments.txt");

    string createTextWindowed = "-screen-fullscreen 0" + Environment.NewLine;
    File.WriteAllText(@"Resources\arguments.txt", createTextWindowed);

    string createTextFullscreen = "-screen-fullscreen 1" + Environment.NewLine;
    File.WriteAllText(@"Resources\arguments.txt", createTextFullscreen);


    if (windowed == true)
        createTextWindowed 
    else
        createTextFullscreen
}

Lines 21 and 23 (createTextWindowed and createTextFullscreen) are errors and I want to fix them but I'm a noob so I don't know how to use the strings I've made, I want to make the program write in the txt file "-screen-fullscreen 0" if windowed = true (I think you got it) and 1 if it's false, I tried this but of course it doesn't work :')

R.Rusev · Accepted Answer · 2016-10-13 08:52:24Z

1

You don't need this because File.WriteAllText truncates the file anyways.

using (var fs = new FileStream(@"Resources\arguments.txt", FileMode.Truncate))
{
}

Remove this as well since it doesn't seem that you are using it
```
string text = File.ReadAllText(@"Resources\arguments.txt");
```

Define a string variable in which to set the text you want to write depending on if it's windowed or not.

string textWrite;

if (windowed == true)
{
    textWrite = "-screen-fullscreen 0" + Environment.NewLine;
}
else
{
    textWrite = "-screen-fullscreen 1" + Environment.NewLine;
}

And lastly just write the text in the file

File.WriteAllText(@"Resources\arguments.txt", textWrite);

Here is the full code of the function after changes:

private void SaveClose_Click(object sender, RoutedEventArgs e)
{
    if (Windowed.IsChecked == true)
        windowed = true;
    else
        windowed = false;

    string textWrite;

    if (windowed == true)
    {
        textWrite = "-screen-fullscreen 0" + Environment.NewLine;
    }
    else
    {
        textWrite = "-screen-fullscreen 1" + Environment.NewLine;
    }

    File.WriteAllText(@"Resources\arguments.txt", textWrite);
}

answered Oct 13, 2016 at 8:52

R.Rusev

1,15115 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Mark Atkinson Over a year ago

It seems they may be looking to append an argument to pre-existing text in the "Resources\arguments.txt" file? Hard to know for sure without confirmation.

Mark Atkinson Over a year ago

I assumed this was a mistaken copy and paste from another answer as an attempt to write to the file, not knowing what the Filemode.Truncate actually did. The body wasn't even in the using directive. However you do make a good point. We will need to wait and see.

Francefire Over a year ago

But now I have a problem, I have to put the full directory of the "argument.txt" (C:\Users\baske\Desktop\Launcher\WpfApplication2\WpfApplication2\Resources\arguments.txt) but in the future I want the program to be on a lot of different computer, and I know that not everybody has the same directory as me for the launcher (and the game) can you please help me with that ? When I put @"Ressources\arguments.txt" it doesn't work, it's not editing the txt file

R.Rusev Over a year ago

@Francefire Have a look at stackoverflow.com/questions/938421/…

Francefire Over a year ago

I am really noob, I don't know where to place them, I tried using System.AppDomain.CurrentDomain.BaseDirectory; but "CurrentDomain" apears as an error :( @R.Rusev

Mark Atkinson · Accepted Answer · 2016-10-13 08:57:34Z

The logical order of your code needs to change, so:

    string text = File.ReadAllText(@"Resources\arguments.txt");

    if (Windowed.IsChecked)
    {
      text = text + "-screen-fullscreen 0" + Environment.NewLine;
    }
    else
    {
      text = text + "-screen-fullscreen 1" + Environment.NewLine;
    }

    File.WriteAllText(@"Resources\arguments.txt", text);

The using directive is not necessary so you can remove that.

Also if the windowed bool is not used outside of this scope, then its not necessary and you can just use the Windowed.IsChecked in the if statement directly. This neatens the code up a bit.

And then you need to think about the flow and logic of the code. So maybe map it out on a piece of paper, my understanding is this:

Read text from "Resources\arguments.txt"
If Windowed.IsChecked is true add argument -screen-fullscreen 0 to text
Else if Windowed.IsChecked is false add argument -screen-fullscreen 0 to text
Save the new text to file.

Maybe look back on your original code with this steps in mind, and see if you can spot the redundant code.

LordWilmore · Accepted Answer · 2016-10-13 08:43:59Z

0

You just need to change your final logic a bit:

if (windowed == true)
{
    string createTextWindowed = "-screen-fullscreen 0" + Environment.NewLine;
    File.WriteAllText(@"Resources\arguments.txt", createTextWindowed);
}
else
{
    string createTextFullscreen = "-screen-fullscreen 1" + Environment.NewLine;
    File.WriteAllText(@"Resources\arguments.txt", createTextFullscreen);
}

Then drop the check at the end

answered Oct 13, 2016 at 8:43

LordWilmore

2,9122 gold badges28 silver badges30 bronze badges

Comments

Mostafiz · Accepted Answer · 2016-10-13 08:49:17Z

0

Try this one

private void SaveClose_Click(object sender, RoutedEventArgs e)
{
    string text = File.ReadAllText(@"Resources\arguments.txt");

    string createTextWindowed = "-screen-fullscreen 0" + Environment.NewLine;
    string createTextFullscreen = "-screen-fullscreen 1" + Environment.NewLine;

    if (Windowed.IsChecked == true)
    {
          File.WriteAllText(@"Resources\arguments.txt", createTextWindowed);
    }
    else
    {
          File.WriteAllText(@"Resources\arguments.txt", createTextFullscreen);
    }
}

edited Oct 13, 2016 at 8:49

answered Oct 13, 2016 at 8:43

Mostafiz

7,3523 gold badges30 silver badges42 bronze badges

Comments

mbadeveloper · Accepted Answer · 2016-10-13 09:10:06Z

0

        string createText;

        if (Windowed.IsChecked){
        createText= "-screen-fullscreen 0" + Environment.NewLine;        
        }
        else{
        createText = "-screen-fullscreen 1" + Environment.NewLine;        
    }
File.WriteAllText(@"Resources\arguments.txt", createText);

edited Oct 13, 2016 at 9:10

answered Oct 13, 2016 at 8:43

mbadeveloper

1,2709 silver badges16 bronze badges

7 Comments

mbadeveloper Over a year ago

@Francefire is that what you want to do? I modify your code to be more simple

Mostafiz Over a year ago

@mbadeveloper why you need FileStream you are using File.WriteAllText

mbadeveloper Over a year ago

Mostafiz you are true I removed the file stream @Francefire please use the new code

Francefire Over a year ago

I'm totally confused now, when I want to try it it says that my txt file is used by another procesus, but no... It shows me a line in another Window (the main windows) but this line is supposed to do something only when I click a button

mbadeveloper Over a year ago

@Francefire I am not sure why you need to read the file in the first statement? if you want only to write the text to the file and lose the file contents because is not important for you then remove the first line string text = File.ReadAllText(@"Resources\arguments.txt");

|

Collectives™ on Stack Overflow

Using my strings in a IF ELSE

5 Answers 5

5 Comments

Comments

Comments

Comments

7 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

5 Comments

Comments

Comments

Comments

7 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related