If statement inside array php

Question

I am trying to update the database with new newpwd only if the new password is entered... Otherwise, i would like it to leave it as it was...

Currently, I am using a workaround and setting it as the password field which is the current password on else. So my question is, is there a way for me to avoid using an else statement? I don't want to update the password row in the database if the new password is not entered.

My code:

$this->db->update("userinfo", array(
'email' => $this->input->post('email'), 
'password' => ($this->input->post('newpwd') !== "") ? md5($this->input->post('newpwd')) : md5($this->input->post('password'))));

Eeeep! Don't use MD5 for password hashing!!! php.net/password_hash — ceejayoz
– ceejayoz, Commented Oct 14, 2016 at 2:28
Don't use md5 for Passwords use php.net/manual/en/function.password-hash.php and php.net/manual/en/function.password-verify.php — user4419336
– user4419336, Commented Oct 14, 2016 at 3:20

Zamrony P. Juhara · Accepted Answer · 2016-10-14 02:35:04Z

2

You need to add it to array conditionally, like following code:

$userData['email'] = $this->input->post('email');
if ($this->input->post('newpwd') !== "") { 
    $userdata['password'] = md5($this->input->post('newpwd'));
}

$this->db->update("userinfo", $userData);

answered Oct 14, 2016 at 2:35

Zamrony P. Juhara

5,2822 gold badges26 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user4419336 Over a year ago

Don't use md5 for Passwords use php.net/manual/en/function.password-hash.php and php.net/manual/en/function.password-verify.php

Zamrony P. Juhara Over a year ago

Yes I know but that is another question.

Amrinder · Accepted Answer · 2016-10-14 02:35:30Z

1

Define array outside of this statement.

$arr = array( 'email' => $this->input->post('email'), );

Only push the 'password' key into the array if new password is entered.

if($this->input->post('newpwd') !== "") { $arrName = array_merge($arr, array('Password' => md5($this->input->post('newpwd')))); }

Then provide the array to update statement like following statement

$this->db->update("userinfo", $arrName);

edited Oct 14, 2016 at 2:35

answered Oct 14, 2016 at 2:28

Amrinder

796 bronze badges

Collectives™ on Stack Overflow

If statement inside array php

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related