push is not a function Angularjs error

Question

Im a starter in Angularjs and learn it now. I got a web application where i want to add a password to a list. The data came from a database. At the start of the project i got the data in an json file and not on the database. After i chaged (data on database) i got the following error.

i got the following code:

$scope.savePassword = function () {
    if ($scope.currentPassword.Id == null) {
        $scope.passwords.push($scope.currentPassword);
        $scope.isShownEdit = false;
    } else {
        var index = $scope.passwords.findIndex(function (item) {
            return item.Id == $scope.currentPassword.Id;
        });
        $scope.passwords[index] = $scope.currentPassword;
        $scope.isShownEdit = false;
    }
}

Here i got the data which should be saved.

<div>
     <!-- Name des Passwortes -->
     <div class="cClearFloat cInputSpace">
         <input placeholder="Name" maxlength="12" ng-model="currentPassword.Name">
     </div>
     <!-- Passwort des Passwortes -->
     <div class="cClearFloat cInputSpace">
         <input placeholder="Passwort" maxlength="12" ng-model="currentPassword.Passwort">
     </div>
     <!-- Beschreibung des Passwortes -->
     <div class="cClearFloat cInputSpace">
         <input placeholder="Beschreibung" maxlength="25" ng-model="currentPassword.Beschreibung">
     </div>
     <!-- Liste mit den kategorien -->
     <div class="cClearFloat cInputSpace">
         <div class="divSmall">
             <label class="inputDropdownPlaceholder">Kategorien</label>
                 <div class="divOptions" ng-repeat="item in categories.Items">
                     <label class="labelDropDown"><input type="checkbox" class="inputDropDown" ng-model="item.isChecked" ng-checked="checkedCategory(item)" ng-init="item.isChecked = checkedCategory(item)" ng-change="changedCategory(item)">{{item.Name}}</label><br>
                 </div>
         </div>
               <div class="cClearFloat cButtons">
                   <button class="cButtonSpeichern" ng-click="showAlertPassword()">Speichern</button>
                   <button class="cButtonAbbrechen" ng-click="isShownEdit = false">Abbrechen</button>
              </div>
     </div>
</div>

check if all fields got an input

    $scope.showAlertPassword = function () {
    if ($scope.currentPassword.Name && $scope.currentPassword.Passwort && $scope.currentPassword.Beschreibung && $scope.currentPassword.Category.length) {
        $scope.savePassword();
    } else {
        alert("Bitte füllen Sie alle Felder korrekt aus!", "Fehler");
    }
}

I implement the data from the database like this:

$scope.passwords = hateoasService.call('http://localhost:20670/passwords');

When i start the application and want to add the data with the "Speichern" click i get the error.

[error image]

I dont know why i get this error can someone help me?

Sravan · Accepted Answer · 2016-10-24 07:44:48Z

1

you used currentPassword instead of $scope.currentPassword,

Change currentPassword instead of $scope.currentPassword and you are done

Then you might be reffering $scope.current_password hash without declaring it.

initialize $scope.current_password = {} at your controller starting.

$scope.savePassword = function () {
    if ($scope.currentPassword.Id == null) {
        $scope.passwords.push($scope.currentPassword);
        $scope.isShownEdit = false;
    } else {
        var index = $scope.passwords.findIndex(function (item) {
            return item.Id == $scope.currentPassword.Id;
        });
        $scope.passwords[index] = $scope.currentPassword;
        $scope.isShownEdit = false;
    }
}

edited Oct 24, 2016 at 7:44

answered Oct 24, 2016 at 7:38

Sravan

18.7k3 gold badges33 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

11 Comments

NiSu Over a year ago

i modified it but the error is the same. this error i got because i modified something and forget to wrote it ;).

Sravan Over a year ago

take $scope.currentPassword = {} at starting of controller

NiSu Over a year ago

the $scope.currentPassword = {} code i got in another controller (global).

Sravan Over a year ago

what is there in password.js line 46

NiSu Over a year ago

this is the push call $scope.passwords.push($scope.currentPassword);

|

charliebeckwith · Accepted Answer · 2016-10-24 07:39:19Z

0

You are pushing currentPassword to the array when elsewhere in your code you are referencing $scope.currentPassword which are two unique references to objects.

Changing it to this should resolve your error: $scope.passwords.push($scope.currentPassword);

answered Oct 24, 2016 at 7:39

charliebeckwith

1,44911 silver badges30 bronze badges

Comments

Jigar7521 · Accepted Answer · 2016-10-24 11:29:26Z

0

You have to first initialize it, then after you can push element into it like :

$scope.passwords = [] // in case of array, | do {} in case of json.

$scope.savePassword = function () {
    if ($scope.currentPassword.Id == null) {
        $scope.passwords.push($scope.currentPassword);
        $scope.isShownEdit = false;
    } else {
        var index = $scope.passwords.findIndex(function (item) {
            return item.Id == $scope.currentPassword.Id;
        });
        $scope.passwords[index] = $scope.currentPassword;
        $scope.isShownEdit = false;
    }
}

answered Oct 24, 2016 at 11:29

Jigar7521

1,5791 gold badge14 silver badges29 bronze badges

Collectives™ on Stack Overflow

push is not a function Angularjs error

3 Answers 3

11 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

11 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related