Need to stop execution Javascript onlick function by element onclick function

Question

<input type = "button" onclick="test()">

Js sample code:

$('input[type=button]').on('click',(function(e){
       e.preventDefault();
      if(!window.confirm(message)) {
         return false;
       }
   }));

I need to stop execution test() for other purposes when click on button. But current situation is it also calling test() instead of return false. Can anyone give suggestion?

@Frédéric Hamidi but the markup is automatically generated so I can not remove it. — imran
– imran, Commented Oct 25, 2016 at 10:39
@imran - if you can target the element, you can remove the handler. It's just a matter of element.removeAttribute('onclick'); where element is a reference to the button. ;) — enhzflep
– enhzflep, Commented Oct 25, 2016 at 10:41
@ enhzflep - but next time again need the onclick function if he confirms :P — imran
– imran, Commented Oct 25, 2016 at 10:46
@imran - If I'd neglected to add detail to the question which would affect the answer given, I certainly wouldn't be sticking out my tongue in the comment that I admitted my mistake. ;) — enhzflep
– enhzflep, Commented Oct 25, 2016 at 10:49

Marc Compte · Accepted Answer · 2016-10-25 10:57:41Z

1

You could remove the onclick event from the HTML markup and add it manually to your code if the user does confirm. It requires you to know which function is associated to the onclick markup attribute and may be complicated if it changes depending on the circumstances. Would this work for you?

// we remove the onclick attribute from the HTML
$('input[type=button]').removeAttribute('onclick');

$('input[type=button]').on('click',(function(e){
   if(!window.confirm(message)) {
       // if user does not confirm, do nothing
       return false;
   } else {
       // if user does confirm, then proceed with the test() function
       test();
   }
}));

answered Oct 25, 2016 at 10:57

Marc Compte

4,8592 gold badges18 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Peter Kalef ' DidiSoft · Accepted Answer · 2016-10-25 10:42:19Z

0

Try to first unbind the previously active onclick:

$('input[type=button]').unbind( 'click' );
$('input[type=button]').on('click',(function(e){
       e.preventDefault();
      if(!window.confirm(message)) {
         return false;
       }
   }));

answered Oct 25, 2016 at 10:42

Peter Kalef ' DidiSoft

1,52417 silver badges22 bronze badges

Collectives™ on Stack Overflow

Need to stop execution Javascript onlick function by element onclick function

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related